#!/usr/bin/env bash # # This bash script installs a modification to the Proxmox Virtual Environment (PVE) web user interface (UI) to display sensors information. # ################### Configuration ############# # Display configuration for HDD, NVME, CPU # Set to 0 to disable line breaks # Note: use these settings only if the displayed layout is broken CPU_ITEMS_PER_ROW=0 NVME_ITEMS_PER_ROW=0 HDD_ITEMS_PER_ROW=0 # Known CPU sensor names. They can be full or partial but should ensure unambiguous identification. # Should new ones be added, also update logic in configure() function. KNOWN_CPU_SENSORS=("coretemp-isa-" "k10temp-pci-") # This script's working directory SCRIPT_CWD="$(dirname "$(readlink -f "$0")")" # Files backup location BACKUP_DIR="$SCRIPT_CWD/backup" # File paths pvemanagerlibjs="/usr/share/pve-manager/js/pvemanagerlib.js" nodespm="/usr/share/perl5/PVE/API2/Nodes.pm" # Debug location DEBUG_SAVE_PATH="$SCRIPT_CWD" DEBUG_SAVE_FILENAME="sensorsdata.json" ##################### DO NOT EDIT BELOW ####################### # Only to be used to debug on other systems. Save the "sensor -j" output into a json file. # Information will be loaded for script configuration and presented in Proxmox. DEBUG_REMOTE=false JSON_FILE="/tmp/sensordata.json" # Helper functions function msg { echo -e "\e[0m$1\e[0m" } #echo message in bold function msgb { echo -e "\e[1m$1\e[0m" } function info { echo -e "\e[0;32m[info] $1\e[0m" } function warn { echo -e "\e[0;93m[warning] $1\e[0m" } function err { echo -e "\e[0;31m[error] $1\e[0m" exit 1 } # End of helper functions # Function to display usage information function usage { msgb "\nUsage:\n$0 [install | uninstall | save-sensors-data]\n" exit 1 } # Define a function to install packages function install_packages { # Check if the 'sensors' command is available on the system if (! command -v sensors &>/dev/null); then # If the 'sensors' command is not available, prompt the user to install lm-sensors read -p "lm-sensors is not installed. Would you like to install it? (y/n) " choice case "$choice" in [yY]) # If the user chooses to install lm-sensors, update the package list and install the package apt-get update apt-get install lm-sensors ;; [nN]) # If the user chooses not to install lm-sensors, exit the script with a zero status code msg "Decided to not install lm-sensors. The mod cannot run without it. Exiting..." exit 0 ;; *) # If the user enters an invalid input, print an error message and exit the script with a non-zero status code err "Invalid input. Exiting..." ;; esac fi } function configure { sensorsDetected=false local sensorsOutput if [ $DEBUG_REMOTE = true ]; then warn "Remote debugging is used. Sensor readings from dump file $JSON_FILE will be used." sensorsOutput=$(cat $JSON_FILE) else sensorsOutput=$(sensors -j) fi if [ $? -ne 0 ]; then err "Sensor output error.\n\nCommand output:\n${sensorsOutput}\n\nExiting...\n" fi # Check if CPU is part of known list for autoconfiguration msg "\nDetecting support for CPU temperature sensors..." for item in "${KNOWN_CPU_SENSORS[@]}"; do if (echo "$sensorsOutput" | grep -q "$item"); then CPU_ADDRESS_PREFIX=$item fi done if [ -n "$CPU_ADDRESS_PREFIX" ]; then msg "Detected sensors:\n$(echo "$sensorsOutput" | grep -o "\"${CPU_ADDRESS_PREFIX}[^\"]*\"" | sed 's/"//g')" # Populate search criterias for known CPUs if (echo "$sensorsOutput" | grep -q "coretemp-"); then # Intel CPU # Prompt user for which temperature to use read -p "Do you wish to display temperatures for all cores [C] or just an average value(s) per CPU [a]? (C/a): " choice case "$choice" in # Set temperature search criteria [cC]|"") if (echo "$sensorsOutput" | grep -A 10 "coretemp-" | grep -q "Core "); then CPU_ITEM_PREFIX="Core " CPU_TEMP_CAPTION="Core" fi ;; [aA] ) if (echo "$sensorsOutput" | grep -A 10 "coretemp-" | grep -q "Package id "); then CPU_ITEM_PREFIX="Package id" CPU_TEMP_CAPTION="Package" fi ;; *) # If the user enters an invalid input, print an error message and exit the script with a non-zero status code err "Invalid input. Exiting..." ;; esac elif (echo "$sensorsOutput" | grep -q "k10temp-"); then # AMD CPU # Find and set temperature search criteria if (echo "$sensorsOutput" | grep -A 4 "$item" | grep -q -e "Tctl" -e "Tccd"); then CPU_ADDRESS_PREFIX=$item CPU_ITEM_PREFIX="Tccd" CPU_TEMP_CAPTION="Temp" elif (echo "$sensorsOutput" | grep -A 4 "$item" | grep -q "temp"); then CPU_ADDRESS_PREFIX=$item CPU_ITEM_PREFIX="temp" CPU_TEMP_CAPTION="Temp" fi fi else # If cpu is not known, ask the user for input warn "Could not automatically detect the CPU temperature sensor. Please configure it manually." # Ask user for CPU information # Inform the user and prompt them to press any key to continue read -rsp $'Sensor output will be presented. Press any key to continue...\n' -n1 key # Print the output to the user msg "Sensor output:\n${sensorsOutput}" # Prompt the user for adapter name and item name read -p "Enter the CPU sensor address prefix (e.g.: coretemp-isa- or k10temp-pci-): " CPU_ADDRESS_PREFIX read -p "Enter the CPU sensor input prefix (e.g.: Core or Tc): " CPU_ITEM_PREFIX read -p "Enter the CPU temperature caption (e.g.: Core or Temp): " CPU_TEMP_CAPTION fi if [[ -z "$CPU_ADDRESS_PREFIX" || -z "$CPU_ITEM_PREFIX" ]]; then warn "The CPU configuration is not complete. Temperatures will not be available." else sensorsDetected=true fi # Check if HDD/SSD data is installed msg "\nDetecting support for HDD/SDD temperature sensors..." if (lsmod | grep -wq "drivetemp"); then # Check if SDD/HDD data is available if (echo "$sensorsOutput" | grep -q "drivetemp-scsi-"); then msg "Detected sensors:\n$(echo "$sensorsOutput" | grep -o '"drivetemp-scsi[^"]*"' | sed 's/"//g')" enableHddTemp=true sensorsDetected=true else warn "Kernel module \"drivetemp\" is not installed. HDD/SDD temperatures will not be available." enableHddTemp=false fi else warn "No HDD/SSD temperature sensors found." enableHddTemp=false fi # Check if NVMe data is available msg "\nDetecting support for NVMe temperature sensors..." if (echo "$sensorsOutput" | grep -q "nvme-"); then msg "Detected sensors:\n$(echo "$sensorsOutput" | grep -o '"nvme[^"]*"' | sed 's/"//g')" enableNvmeTemp=true sensorsDetected=true else warn "No NVMe temperature sensors found." enableNvmeTemp=false fi # Look for fan speeds msg "\nDetecting support for fan speed readings..." if (echo "$sensorsOutput" | grep -q "fan[0-9]*_input"); then msg "Detected fan speed sensors:\n$(echo $sensorsOutput | grep -Po '"[^"]*":\s*\{\s*"fan[0-9]*_input[^}]*' | sed -E 's/"([^"]*)":.*/\1/')" enableFanSpeed=true sensorsDetected=true # Prompt user for display zero speed fans read -p "Do you wish to display fans reporting a speed of zero? If no, only active fans will be displayed? (Y/n): " choice case "$choice" in # Set temperature search criteria [yY]|"") displayZeroSpeedFans=true ;; [nN] ) displayZeroSpeedFans=false ;; *) # If the user enters an invalid input, print an error message and exit the script with a non-zero status code err "Invalid input. Exiting..." ;; esac else warn "No fan speed sensors found." enableFanSpeed=false fi if [ $sensorsDetected = true ]; then echo read -p "Do you wish to display temperature readings in degrees Celsius [C] or Fahrenheit [f]? (C/f): " TEMP_UNIT case "$TEMP_UNIT" in [cC] | "") TEMP_UNIT="C" info "Temperatures will be presented in degrees Celsius." ;; [fF]) TEMP_UNIT="F" info "Temperatures will be presented in degrees Fahrenheit." ;; *) warn "Invalid unit selected. Temperatures will be displayed in degrees Celsius." TEMP_UNIT="C" ;; esac fi echo read -p "Do you wish to enable system information? (Y/n): " ENABLE_SYS_INFO case "$ENABLE_SYS_INFO" in [yY] | "") enableSystemInfo=true info "System information will be displayed..." ;; [nN]) enableSystemInfo=false info "System information will NOT be displayed..." ;; *) warn "Invalid selection. System information will be displayed." enableSystemInfo=true ;; esac echo # add a new line } # Function to install the modification function install_mod { msg "\nPreparing mod installation..." # Provide sensor configuration configure # Create backup of original files mkdir -p "$BACKUP_DIR" local timestamp=$(date '+%Y-%m-%d_%H-%M-%S') # Perform backup if [[ -z $(cat $nodespm | grep -e "$res->{sensorsOutput}") ]] || [[ -z $(cat $nodespm | grep -e "$res->{systemInfo}") ]]; then # Create backup of original file cp "$nodespm" "$BACKUP_DIR/Nodes.pm.$timestamp" msg "Backup of \"$nodespm\" saved to \"$BACKUP_DIR/Nodes.pm.$timestamp\"." # Create backup of original file cp "$pvemanagerlibjs" "$BACKUP_DIR/pvemanagerlib.js.$timestamp" msg "Backup of \"$pvemanagerlibjs\" saved to \"$BACKUP_DIR/pvemanagerlib.js.$timestamp\"." else err "Mod is already installed. Uninstall existing before installing." exit fi enableSensors=true if [[ "$enableSensors" == true ]]; then local sensorsCmd if [ $DEBUG_REMOTE = true ]; then sensorsCmd="cat \"$JSON_FILE\"" else # WTF: sensors -f used for Fahrenheit breaks the fan speeds :| #local sensorsCmd=$([[ "$TEMP_UNIT" = "F" ]] && echo "sensors -j -f" || echo "sensors -j") sensorsCmd="sensors -j" fi sed -i '/my \$dinfo = df('\''\/'\'', 1);/i\'$'\t''$res->{sensorsOutput} = `'"$sensorsCmd"'`;\n\t# sanitize JSON output\n\t$res->{sensorsOutput} =~ s/ERROR:.+\\s(\\w+):\\s(.+)/\\"$1\\": 0.000,/g;\n\t$res->{sensorsOutput} =~ s/ERROR:.+\\s(\\w+)!/\\"$1\\": 0.000,/g;\n\t$res->{sensorsOutput} =~ s/,(.*[.\\n]*.+})/$1/g;\n' "$nodespm" msg "Sensors' output added to \"$nodespm\"." fi if [[ "$enableSystemInfo" == true ]]; then local systemInfoCmd=$(dmidecode -t 1 | awk -F': ' '/Manufacturer|Product Name|Serial Number/ {print $1": "$2}' | awk '{$1=$1};1' | sed 's/$/ |/' | paste -sd " " - | sed 's/ |$//') sed -i "/my \$dinfo = df('\/', 1);/i\\\t\$res->{systemInfo} = \"$(echo "$systemInfoCmd")\";\n" "$nodespm" msg "System information output added to \"$nodespm\"." fi # Add new item to the items array in PVE.node.StatusView if [[ -z $(cat "$pvemanagerlibjs" | grep -e "itemId: 'thermal[[:alnum:]]*'") ]]; then local tempHelperCtorParams=$([[ "$TEMP_UNIT" = "F" ]] && echo '{srcUnit: PVE.mod.TempHelper.CELSIUS, dstUnit: PVE.mod.TempHelper.FAHRENHEIT}' || echo '{srcUnit: PVE.mod.TempHelper.CELSIUS, dstUnit: PVE.mod.TempHelper.CELSIUS}') # Expand space in StatusView sed -i "/Ext.define('PVE\.node\.StatusView'/,/\},/ { s/\(bodyPadding:\) '[^']*'/\1 '20 15 20 15'/ s/height: [0-9]\+/minHeight: 360,\n\tflex: 1,\n\tcollapsible: true,\n\ttitleCollapse: true/ s/\(tableAttrs:.*$\)/trAttrs: \{ valign: 'top' \},\n\t\1/ }" "$pvemanagerlibjs" msg "Expanded space in \"$pvemanagerlibjs\"." sed -i "/^Ext.define('PVE.node.StatusView'/i\ Ext.define('PVE.mod.TempHelper', {\n\ //singleton: true,\n\ \n\ requires: ['Ext.util.Format'],\n\ \n\ statics: {\n\ CELSIUS: 0,\n\ FAHRENHEIT: 1\n\ },\n\ \n\ srcUnit: null,\n\ dstUnit: null,\n\ \n\ isValidUnit: function (unit) {\n\ return (\n\ Ext.isNumber(unit) && (unit === this.self.CELSIUS || unit === this.self.FAHRENHEIT)\n\ );\n\ },\n\ \n\ constructor: function (config) {\n\ this.srcUnit = config && this.isValidUnit(config.srcUnit) ? config.srcUnit : this.self.CELSIUS;\n\ this.dstUnit = config && this.isValidUnit(config.dstUnit) ? config.dstUnit : this.self.CELSIUS;\n\ },\n\ \n\ toFahrenheit: function (tempCelsius) {\n\ return Ext.isNumber(tempCelsius)\n\ ? tempCelsius * 9 / 5 + 32\n\ : NaN;\n\ },\n\ \n\ toCelsius: function (tempFahrenheit) {\n\ return Ext.isNumber(tempFahrenheit)\n\ ? (tempFahrenheit - 32) * 5 / 9\n\ : NaN;\n\ },\n\ \n\ getTemp: function (value) {\n\ if (this.srcUnit !== this.dstUnit) {\n\ switch (this.srcUnit) {\n\ case this.self.CELSIUS:\n\ switch (this.dstUnit) {\n\ case this.self.FAHRENHEIT:\n\ return this.toFahrenheit(value);\n\ \n\ default:\n\ Ext.raise({\n\ msg:\n\ 'Unsupported destination temperature unit: ' + this.dstUnit,\n\ });\n\ }\n\ case this.self.FAHRENHEIT:\n\ switch (this.dstUnit) {\n\ case this.self.CELSIUS:\n\ return this.toCelsius(value);\n\ \n\ default:\n\ Ext.raise({\n\ msg:\n\ 'Unsupported destination temperature unit: ' + this.dstUnit,\n\ });\n\ }\n\ default:\n\ Ext.raise({\n\ msg: 'Unsupported source temperature unit: ' + this.srcUnit,\n\ });\n\ }\n\ } else {\n\ return value;\n\ }\n\ },\n\ \n\ getUnit: function(plainText) {\n\ switch (this.dstUnit) {\n\ case this.self.CELSIUS:\n\ return plainText !== true ? '\°C' : '\\\'C';\n\ \n\ case this.self.FAHRENHEIT:\n\\n\ return plainText !== true ? '\°F' : '\\\'F';\n\ \n\ default:\n\ Ext.raise({\n\ msg: 'Unsupported destination temperature unit: ' + this.srcUnit,\n\ });\n\ }\n\ },\n\ });\n" "$pvemanagerlibjs" if [[ $enableSystemInfo == "true" ]]; then sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /cpus.*},/!{N;bb;} a\ \\ {\n\ itemId: 'sysinfo',\n\ colspan: 2,\n\ printBar: false,\n\ title: gettext('System Information'),\n\ textField: 'systemInfo',\n\ renderer: function(value){\n\ return value;\n\ }\n\ }, }" "$pvemanagerlibjs" fi sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /cpus.*},/!{N;bb;} a\ \\ {\n\ itemId: 'thermalCpu',\n\ colspan: 2,\n\ printBar: false,\n\ title: gettext('CPU Thermal State'),\n\ iconCls: 'fa fa-fw fa-thermometer-half',\n\ textField: 'sensorsOutput',\n\ renderer: function(value){\n\ // sensors configuration\n\ const addressPrefix = \"$CPU_ADDRESS_PREFIX\";\n\ const cpuItemPrefix = \"$CPU_ITEM_PREFIX\";\n\ const cpuTempCaption = \"$CPU_TEMP_CAPTION\";\n\ const cpuTempHelper = Ext.create('PVE.mod.TempHelper', $tempHelperCtorParams);\n\ // display configuration\n\ const itemsPerRow = $CPU_ITEMS_PER_ROW;\n\ // ---\n\ let objValue;\n\ try {\n\ objValue = JSON.parse(value) || {};\n\ } catch(e) {\n\ objValue = {};\n\ }\n\ const cpuKeys = Object.keys(objValue).filter(item => String(item).startsWith(addressPrefix)).sort();\n\ const cpuCount = cpuKeys.length;\n\ let temps = [];\n\ cpuKeys.forEach((cpuKey, cpuIndex) => {\n\ let cpuTemps = [];\n\ const items = objValue[cpuKey];\n\ const itemKeys = Object.keys(items).filter(item => { return String(item).startsWith(cpuItemPrefix); });\n\ itemKeys.forEach((coreKey) => {\n\ try {\n\ let tempVal = NaN, tempMax = NaN, tempCrit = NaN;\n\ Object.keys(items[coreKey]).forEach((secondLevelKey) => {\n\ if (secondLevelKey.endsWith('_input')) {\n\ tempVal = cpuTempHelper.getTemp(parseFloat(items[coreKey][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_max')) {\n\ tempMax = cpuTempHelper.getTemp(parseFloat(items[coreKey][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_crit')) {\n\ tempCrit = cpuTempHelper.getTemp(parseFloat(items[coreKey][secondLevelKey]));\n\ }\n\ });\n\ if (!isNaN(tempVal)) {\n\ let tempStyle = '';\n\ if (!isNaN(tempMax) && tempVal >= tempMax) {\n\ tempStyle = 'color: #FFC300; font-weight: bold;';\n\ }\n\ if (!isNaN(tempCrit) && tempVal >= tempCrit) {\n\ tempStyle = 'color: red; font-weight: bold;';\n\ }\n\ let tempStr = '';\n\ let tempIndex = coreKey.match(/\\\S+\\\s*(\\\d+)/);\n\ if (tempIndex !== null && tempIndex.length > 1) {\n\ tempIndex = tempIndex[1];\n\ tempStr = \`\${cpuTempCaption} \${tempIndex}: \${Ext.util.Format.number(tempVal, '0.#')}\${cpuTempHelper.getUnit()}\`;\n\ } else {\n\ tempStr = \`\${cpuTempCaption}: \${Ext.util.Format.number(tempVal, '0.#')}\${cpuTempHelper.getUnit()}\`;\n\ }\n\ cpuTemps.push(tempStr);\n\ }\n\ } catch (e) { /*_*/ }\n\ });\n\ if(cpuTemps.length > 0) {\n\ temps.push(cpuTemps);\n\ }\n\ });\n\ let result = '';\n\ temps.forEach((cpuTemps, cpuIndex) => {\n\ const strCoreTemps = cpuTemps.map((strTemp, index, arr) => { return strTemp + (index + 1 < arr.length ? (itemsPerRow > 0 && (index + 1) % itemsPerRow === 0 ? '
' : ' | ') : ''); })\n\ if(strCoreTemps.length > 0) {\n\ result += (cpuCount > 1 ? \`CPU \${cpuIndex+1}: \` : '') + strCoreTemps.join('') + (cpuIndex < cpuCount ? '
' : '');\n\ }\n\ });\n\ return '
' + (result.length > 0 ? result : 'N/A') + '
';\n\ }\n\ }, }" "$pvemanagerlibjs" # # NOTE: The following items will be added in reverse order # if [ $enableHddTemp = true ]; then sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /'thermal.*},/!{N;bb;} a\ \\ {\n\ itemId: 'thermalHdd',\n\ colspan: 2,\n\ printBar: false,\n\ title: gettext('HDD/SSD Thermal State'),\n\ iconCls: 'fa fa-fw fa-thermometer-half',\n\ textField: 'sensorsOutput',\n\ renderer: function(value) {\n\ // sensors configuration\n\ const addressPrefix = \"drivetemp-scsi-\";\n\ const sensorName = \"temp1\";\n\ const tempHelper = Ext.create('PVE.mod.TempHelper', $tempHelperCtorParams);\n\ // display configuration\n\ const itemsPerRow = ${HDD_ITEMS_PER_ROW};\n\ // ---\n\ let objValue;\n\ try {\n\ objValue = JSON.parse(value) || {};\n\ } catch(e) {\n\ objValue = {};\n\ }\n\ const drvKeys = Object.keys(objValue).filter(item => String(item).startsWith(addressPrefix)).sort();\n\ let temps = [];\n\ drvKeys.forEach((drvKey, index) => {\n\ try {\n\ let tempVal = NaN, tempMax = NaN, tempCrit = NaN;\n\ Object.keys(objValue[drvKey][sensorName]).forEach((secondLevelKey) => {\n\ if (secondLevelKey.endsWith('_input')) {\n\ tempVal = tempHelper.getTemp(parseFloat(objValue[drvKey][sensorName][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_max')) {\n\ tempMax = tempHelper.getTemp(parseFloat(objValue[drvKey][sensorName][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_crit')) {\n\ tempCrit = tempHelper.getTemp(parseFloat(objValue[drvKey][sensorName][secondLevelKey]));\n\ }\n\ });\n\ if (!isNaN(tempVal)) {\n\ let tempStyle = '';\n\ if (!isNaN(tempMax) && tempVal >= tempMax) {\n\ tempStyle = 'color: #FFC300; font-weight: bold;';\n\ }\n\ if (!isNaN(tempCrit) && tempVal >= tempCrit) {\n\ tempStyle = 'color: red; font-weight: bold;';\n\ }\n\ const tempStr = \`Drive \${index + 1}: \${Ext.util.Format.number(tempVal, '0.#')}\${tempHelper.getUnit()}\`;\n\ temps.push(tempStr);\n\ }\n\ } catch(e) { /*_*/ }\n\ });\n\ const result = temps.map((strTemp, index, arr) => { return strTemp + (index + 1 < arr.length ? ((index + 1) % itemsPerRow === 0 ? '
' : ' | ') : ''); });\n\ return '
' + (result.length > 0 ? result.join('') : 'N/A') + '
';\n\ }\n\ }, }" "$pvemanagerlibjs" fi if [ $enableNvmeTemp = true ]; then sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /'thermal.*},/!{N;bb;} a\ \\ {\n\ itemId: 'thermalNvme',\n\ colspan: 2,\n\ printBar: false,\n\ title: gettext('NVMe Thermal State'),\n\ iconCls: 'fa fa-fw fa-thermometer-half',\n\ textField: 'sensorsOutput',\n\ renderer: function(value) {\n\ // sensors configuration\n\ const addressPrefix = \"nvme-pci-\";\n\ const sensorName = \"Composite\";\n\ const tempHelper = Ext.create('PVE.mod.TempHelper', $tempHelperCtorParams);\n\ // display configuration\n\ const itemsPerRow = ${NVME_ITEMS_PER_ROW};\n\ // ---\n\ let objValue;\n\ try {\n\ objValue = JSON.parse(value) || {};\n\ } catch(e) {\n\ objValue = {};\n\ }\n\ const nvmeKeys = Object.keys(objValue).filter(item => String(item).startsWith(addressPrefix)).sort();\n\ let temps = [];\n\ nvmeKeys.forEach((nvmeKey, index) => {\n\ try {\n\ let tempVal = NaN, tempMax = NaN, tempCrit = NaN;\n\ Object.keys(objValue[nvmeKey][sensorName]).forEach((secondLevelKey) => {\n\ if (secondLevelKey.endsWith('_input')) {\n\ tempVal = tempHelper.getTemp(parseFloat(objValue[nvmeKey][sensorName][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_max')) {\n\ tempMax = tempHelper.getTemp(parseFloat(objValue[nvmeKey][sensorName][secondLevelKey]));\n\ } else if (secondLevelKey.endsWith('_crit')) {\n\ tempCrit = tempHelper.getTemp(parseFloat(objValue[nvmeKey][sensorName][secondLevelKey]));\n\ }\n\ });\n\ if (!isNaN(tempVal)) {\n\ let tempStyle = '';\n\ if (!isNaN(tempMax) && tempVal >= tempMax) {\n\ tempStyle = 'color: #FFC300; font-weight: bold;';\n\ }\n\ if (!isNaN(tempCrit) && tempVal >= tempCrit) {\n\ tempStyle = 'color: red; font-weight: bold;';\n\ }\n\ const tempStr = \`Drive \${index + 1}: \${Ext.util.Format.number(tempVal, '0.#')}\${tempHelper.getUnit()}\`;\n\ temps.push(tempStr);\n\ }\n\ } catch(e) { /*_*/ }\n\ });\n\ const result = temps.map((strTemp, index, arr) => { return strTemp + (index + 1 < arr.length ? ((index + 1) % itemsPerRow === 0 ? '
' : ' | ') : ''); });\n\ return '
' + (result.length > 0 ? result.join('') : 'N/A') + '
';\n\ }\n\ }, }" "$pvemanagerlibjs" fi if [ $enableNvmeTemp = true -o $enableHddTemp = true ]; then sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /'thermal.*},/!{N;bb;} a\ \\ {\n\ xtype: 'box',\n\ colspan: 2,\n\ html: gettext('Drive(s)'),\n\ }, }" "$pvemanagerlibjs" fi if [ $enableFanSpeed = true ]; then # Add fan speeds display sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /items:/!{N;ba;} :b; /'thermal.*},/!{N;bb;} a\ \\ {\n\ xtype: 'box',\n\ colspan: 2,\n\ html: gettext('Cooling'),\n\ },\n\ {\n\ itemId: 'speedFan',\n\ colspan: 2,\n\ printBar: false,\n\ title: gettext('Fan Speed(s)'),\n\ iconCls: 'fa fa-fw fa-snowflake-o',\n\ textField: 'sensorsOutput',\n\ renderer: function(value) {\n\ // ---\n\ let objValue;\n\ try {\n\ objValue = JSON.parse(value) || {};\n\ } catch(e) {\n\ objValue = {};\n\ }\n\ \n\ // Recursive function to find fan keys and values\n\ function findFanKeys(obj, fanKeys, parentKey = null) {\n\ Object.keys(obj).forEach(key => {\n\ const value = obj[key];\n\ if (typeof value === 'object' && value !== null) {\n\ // If the value is an object, recursively call the function\n\ findFanKeys(value, fanKeys, key);\n\ } else if (/^fan[0-9]+(_input)?$/.test(key)) {\n\ if ($displayZeroSpeedFans != true && value === 0) {\n\ // Skip this fan if displayZeroSpeedFans is false and value is 0\n\ return;\n\ }\n\ // If the key matches the pattern, add the parent key and value to the fanKeys array\n\ fanKeys.push({ key: parentKey, value: value });\n\ }\n\ });\n\ }\n\ \n\ let speeds = [];\n\ // Loop through the parent keys\n\ Object.keys(objValue).forEach(parentKey => {\n\ const parentObj = objValue[parentKey];\n\ // Array to store fan keys and values\n\ const fanKeys = [];\n\ // Call the recursive function to find fan keys and values\n\ findFanKeys(parentObj, fanKeys);\n\ // Sort the fan keys\n\ fanKeys.sort();\n\ // Process each fan key and value\n\ fanKeys.forEach(({ key: fanKey, value: fanSpeed }) => {\n\ try {\n\ const fan = fanKey.charAt(0).toUpperCase() + fanKey.slice(1); // Capitalize the first letter of fanKey\n\ speeds.push(\`\${fan}: \${fanSpeed} RPM\`);\n\ } catch(e) {\n\ console.error(\`Error retrieving fan speed for \${fanKey} in \${parentKey}:\`, e); // Debug: Log specific error\n\ }\n\ });\n\ });\n\ return '
' + (speeds.length > 0 ? speeds.join(' | ') : 'N/A') + '
';\n\ }\n\ }, }" "$pvemanagerlibjs" fi # Add an empty line to separate modified items as a visual group # NOTE: Check for the presence of items in the reverse order of display local lastItemId="" if [ $enableHddTemp = true ]; then lastItemId="thermalHdd" elif [ $enableNvmeTemp = true ]; then lastItemId="thermalNvme" elif [ $enableFanSpeed = true ]; then lastItemId="speedFan" else lastItemId="thermalCpu" fi if [ -n "$lastItemId" ]; then sed -i "/^Ext.define('PVE.node.StatusView',/ { :a; /^.*{.*'$lastItemId'.*},/!{N;ba;} a\ \\ {\n\ xtype: 'box',\n\ colspan: 2,\n\ padding: '0 0 20 0',\n\ }, }" "$pvemanagerlibjs" fi # Move the node summary box into its own container sed -i "/^\s*nodeStatus: nodeStatus,/ { :a /items: \[/ !{N;ba;} a\ \\ {\n\ xtype: 'container',\n\ itemId: 'summarycontainer',\n\ layout: 'column',\n\ minWidth: 700,\n\ defaults: {\n\ minHeight: 350,\n\ padding: 5,\n\ columnWidth: 1,\n\ },\n\ items: [\n\ nodeStatus,\n\ ]\n\ }, }" "$pvemanagerlibjs" # Deactivate the original box instance sed -i "/^\s*nodeStatus: nodeStatus,/ { :a /itemId: 'itemcontainer',/ !{N;ba;} n; :b /nodeStatus,/ !{N;bb;} s/nodeStatus/\/\/nodeStatus/ }" "$pvemanagerlibjs" msg "Sensor display items added to the summary panel in \"$pvemanagerlibjs\"." restart_proxy msg "Installation completed." info "Clear the browser cache to ensure all changes are visualized." else warn "Sensor display items already added to the summary panel in \"$pvemanagerlibjs\"." fi } # Function to uninstall the modification function uninstall_mod { msg "\nRestoring modified files..." # Find the latest Nodes.pm file using the find command local latest_nodes_pm=$(find "$BACKUP_DIR" -name "Nodes.pm.*" -type f -printf '%T+ %p\n' 2>/dev/null | sort -r | head -n 1 | awk '{print $2}') if [ -n "$latest_nodes_pm" ]; then # Remove the latest Nodes.pm file cp "$latest_nodes_pm" "$nodespm" msg "Copied latest backup to $nodespm." else warn "No Nodes.pm files found." fi # Find the latest pvemanagerlib.js file using the find command local latest_pvemanagerlibjs=$(find "$BACKUP_DIR" -name "pvemanagerlib.js.*" -type f -printf '%T+ %p\n' 2>/dev/null | sort -r | head -n 1 | awk '{print $2}') if [ -n "$latest_pvemanagerlibjs" ]; then # Remove the latest pvemanagerlib.js file cp "$latest_pvemanagerlibjs" "$pvemanagerlibjs" msg "Copied latest backup to \"$pvemanagerlibjs\"." else warn "No pvemanagerlib.js files found." fi if [ -n "$latest_nodes_pm" ] || [ -n "$latest_pvemanagerlibjs" ]; then # At least one of the variables is not empty, restart the proxy restart_proxy fi } function restart_proxy { # Restart pveproxy msg "\nRestarting PVE proxy..." systemctl restart pveproxy } function save_sensors_data { # Check if DEBUG_SAVE_PATH exists and is writable if [[ ! -d "$DEBUG_SAVE_PATH" || ! -w "$DEBUG_SAVE_PATH" ]]; then err "Directory $DEBUG_SAVE_PATH does not exist or is not writable. No file could be saved." return fi # Check if command exists if (command -v sensors &>/dev/null); then # Save sensors output local filepath="${DEBUG_SAVE_PATH}/${DEBUG_SAVE_FILENAME}" msg "Sensors data will be saved in $filepath" # Prompt user for confirmation read -p "Do you wish to continue? (y/n): " choice case "$choice" in [yY]) sensors -j >"$filepath" msgb "Sensors data saved in $filepath." ;; *) warn "Operation cancelled by user." ;; esac else err "Sensors is not installed. No file could be saved." fi } # Process the arguments using a while loop and a case statement executed=0 while [[ $# -gt 0 ]]; do case "$1" in install) executed=$(($executed + 1)) msgb "\nInstalling the Proxmox VE sensors display mod..." install_packages install_mod echo # add a new line ;; uninstall) executed=$(($executed + 1)) msgb "\nUninstalling the Proxmox VE sensors display mod..." uninstall_mod echo # add a new line ;; save-sensors-data) executed=$(($executed + 1)) msgb "\nSaving current sensor readings in a file for debugging..." save_sensors_data echo # add a new line ;; esac shift done # If no arguments were provided or all arguments have been processed, print the usage message if [[ $executed -eq 0 ]]; then usage fi