From 507f2bfafd3797b9a0425a77b63fbbd71dfe9c51 Mon Sep 17 00:00:00 2001
From: Charles Thomas <ch@rlesthom.as>
Date: Fri, 12 Jul 2024 17:54:51 -0400
Subject: [PATCH] fix: don't show "partial" if there are completed job pods

i'm using a kubernetes service that includes a web UI and cronjobs.
because the job finish and go to status `Completed`, the homepage link
to the web UI shows `partial` instead of `running`

this patch updates the `someReady` & `allReady` pod filter to include
pods that are both `Running` and `Completed`
---
 src/pages/api/kubernetes/status/[...service].js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/pages/api/kubernetes/status/[...service].js b/src/pages/api/kubernetes/status/[...service].js
index 7d950038..b25cd69d 100644
--- a/src/pages/api/kubernetes/status/[...service].js
+++ b/src/pages/api/kubernetes/status/[...service].js
@@ -48,8 +48,8 @@ export default async function handler(req, res) {
       logger.error(`no pods found with namespace=${namespace} and labelSelector=${labelSelector}`);
       return;
     }
-    const someReady = pods.find((pod) => pod.status.phase === "Running");
-    const allReady = pods.every((pod) => pod.status.phase === "Running");
+    const someReady = pods.find((pod) => pod.status.phase in ["Completed", "Running"]);
+    const allReady = pods.every((pod) => pod.status.phase in ["Completed", "Running"]);
     let status = "down";
     if (allReady) {
       status = "running";