OpenSource/homepage
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Code improvement

Browse Source
This commit is contained in:
shamoon 2024-11-21 15:14:32 -08:00
parent e650470491
commit a2e139e02d
1 changed files with 10 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/widgets/spoolman/component.jsx
View File

@ -8,24 +8,13 @@ export default function Component({ service }) {
const { t } = useTranslation(); const { t } = useTranslation();
const { widget } = service; const { widget } = service;
const { data: spoolData, error: spoolError } = useWidgetAPI(widget, "spools"); // eslint-disable-next-line prefer-const
let { data: spoolData, error: spoolError } = useWidgetAPI(widget, "spools");
// Helper to handle filtering based on spoolIds
const filterSpools = (data, spoolIds) => {
if (!spoolIds || spoolIds.length === 0) return data; // No filtering if no spoolIds
const limitedspoolIds = spoolIds.slice(0, 4); // Limit to 4 names
return data.filter(spool => spoolIds.includes(spool.id));
};
// Helper to limit spoolData length
const limitSpoolData = (data, limit = 4) => (data.length > limit ? data.slice(0, limit) : data);
// Error handling
if (spoolError) { if (spoolError) {
return <Container service={service} error={spoolError} />; return <Container service={service} error={spoolError} />;
} }
// Loading state
if (!spoolData) { if (!spoolData) {
return ( return (
<Container service={service}> <Container service={service}>
@ -35,12 +24,10 @@ export default function Component({ service }) {
); );
} }
// API error or unexpected response
if (spoolData.error || spoolData.message) { if (spoolData.error || spoolData.message) {
return <Container service={service} error={spoolData?.error ?? spoolData} />; return <Container service={service} error={spoolData?.error ?? spoolData} />;
} }
// No spools available
if (spoolData.length === 0) { if (spoolData.length === 0) {
return ( return (
<Container service={service}> <Container service={service}>
@ -49,14 +36,17 @@ export default function Component({ service }) {
); );
} }
// Filter and limit spools if (widget.spoolIds?.length) {
let filteredSpoolData = filterSpools(spoolData, widget.spoolIds); spoolData = spoolData.filter((spool) => widget.spoolIds.includes(spool.id));
filteredSpoolData = limitSpoolData(filteredSpoolData); }
if (spoolData.length > 4) {
spoolData = spoolData.slice(0, 4);
}
// Render filtered and limited spools
return ( return (
<Container service={service}> <Container service={service}>
{filteredSpoolData.map((spool) => ( {spoolData.map((spool) => (
<Block <Block
key={spool.id} key={spool.id}
label={spool.filament.name} label={spool.filament.name}