OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor: remove unnecessary conditional depth

Browse Source
This commit is contained in:
Gayun00 2023-09-25 18:37:10 +09:00
parent 87131ef926
commit 022eded430
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
TypeScript/app/gilded-rose.ts
View File

@ -10,11 +10,6 @@ export class Item {
this.sellIn = sellIn; this.sellIn = sellIn;
this.quality = quality; this.quality = quality;
} }
// handleSellIn() {
// if (this.name === ITEMS.SURFRAS) return;
// this.sellIn--;
// }
} }
export class GildedRose { export class GildedRose {
@ -25,14 +20,13 @@ export class GildedRose {
} }
handlePassesQuality(item) { handlePassesQuality(item) {
if (item.name == ITEMS.PASSES) { if (item.name !== ITEMS.PASSES) return;
if (6 <= item.sellIn && item.sellIn < 11) { if (6 <= item.sellIn && item.sellIn < 11) {
item.quality += 1; item.quality += 1;
} }
if (item.sellIn < 6) { if (item.sellIn < 6) {
item.quality += 2; item.quality += 2;
}
} }
} }
@ -45,7 +39,7 @@ export class GildedRose {
item.quality = item.quality + 1; item.quality = item.quality + 1;
break; break;
case ITEMS.SURFRAS: case ITEMS.SURFRAS:
item.quality = item.quality - item.quality; item.quality = 0;
break; break;
default: default:
if (!item.quality) return; if (!item.quality) return;