name refactor

This commit is contained in:
cammp325 2022-07-02 10:36:02 -04:00
parent 7d271910c2
commit 02f5234955

View File

@ -2,6 +2,10 @@ package com.gildedrose;
class GildedRose { class GildedRose {
public static final String AGED_BRIE = "Aged Brie";
public static final String SULFURAS = "Sulfuras, Hand of Ragnaros";
public static final String BACKSTAGE = "Backstage passes to a TAFKAL80ETC concert";
private Item[] items; private Item[] items;
public GildedRose(Item... items) { public GildedRose(Item... items) {
@ -9,62 +13,57 @@ class GildedRose {
} }
public void updateQuality() { public void updateQuality() {
for (Item item : items) { for (int i = 0; i < items.length; i++) {
updateItemQuality(item); if (!items[i].name.equals(AGED_BRIE)
} && !items[i].name.equals(BACKSTAGE)) {
} if (items[i].quality > 0) {
if (!items[i].name.equals(SULFURAS)) {
private void updateItemQuality(Item item) { items[i].quality = items[i].quality - 1;
if (!item.name.equals("Aged Brie")
&& !item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
} }
} }
} else { } else {
if (item.quality < 50) { if (items[i].quality < 50) {
item.quality = item.quality + 1; items[i].quality = items[i].quality + 1;
if (item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals(BACKSTAGE)) {
if (item.sellIn < 11) { if (items[i].sellIn < 11) {
if (item.quality < 50) { if (items[i].quality < 50) {
item.quality = item.quality + 1; items[i].quality = items[i].quality + 1;
} }
} }
if (item.sellIn < 6) { if (items[i].sellIn < 6) {
if (item.quality < 50) { if (items[i].quality < 50) {
item.quality = item.quality + 1; items[i].quality = items[i].quality + 1;
} }
} }
} }
} }
} }
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS)) {
item.sellIn = item.sellIn - 1; items[i].sellIn = items[i].sellIn - 1;
} }
if (item.sellIn < 0) { if (items[i].sellIn < 0) {
if (!item.name.equals("Aged Brie")) { if (!items[i].name.equals(AGED_BRIE)) {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!items[i].name.equals(BACKSTAGE)) {
if (item.quality > 0) { if (items[i].quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals(SULFURAS)) {
item.quality = item.quality - 1; items[i].quality = items[i].quality - 1;
} }
} }
} else { } else {
item.quality = item.quality - item.quality; items[i].quality = items[i].quality - items[i].quality;
} }
} else { } else {
if (item.quality < 50) { if (items[i].quality < 50) {
item.quality = item.quality + 1; items[i].quality = items[i].quality + 1;
} }
} }
} }
} }
}
public Item[] getItems() { public Item[] getItems() {
return items; return items;