OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Move conditional into sellInBelow0

Browse Source
This commit is contained in:
Jesper 2022-04-13 16:35:03 +02:00
parent 2bf8dbde29
commit 138ad0daab
1 changed files with 16 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
TypeScript/app/gilded-rose.ts
View File

@ -45,32 +45,31 @@ export class GildedRose {
if (item.name != 'Sulfuras, Hand of Ragnaros') { if (item.name != 'Sulfuras, Hand of Ragnaros') {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }
if (item.sellIn < 0) { item.quality = this.sellInBelow0(item)
item.quality = this.sellInBelow0(item)
}
}) })
return this.items; return this.items;
} }
private sellInBelow0(item: Item): number { private sellInBelow0(item: Item): number {
if (item.name == 'Sulfuras, Hand of Ragnaros') return item.quality; if (item.sellIn < 0) {
if (item.name == 'Sulfuras, Hand of Ragnaros') return item.quality;
if (item.name == 'Aged Brie') { if (item.name == 'Aged Brie') {
if (item.quality < 50) { if (item.quality < 50) {
return item.quality + 1 return item.quality + 1
}
return item.quality
} }
return item.quality
}
if (item.name == 'Backstage passes to a TAFKAL80ETC concert') { if (item.name == 'Backstage passes to a TAFKAL80ETC concert') {
return 0 return 0
} }
if (item.quality > 0) { if (item.quality > 0) {
return item.quality - 1 return item.quality - 1
}
} }
return item.quality return item.quality
} }
} }