OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add tests for conjured on and after sellIn date is zero

Browse Source
This commit is contained in:
Kirti Deshmukh 2023-02-03 08:05:11 +05:30
parent eb48f26dc3
commit 172bb39d30
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -18,8 +18,9 @@ class GildedRose {
private void updateQualityForConjured(Item item) { private void updateQualityForConjured(Item item) {
if (item.sellIn > 0) { if (item.sellIn > 0) {
item.quality = degradeQualityBy(item.quality, 2); item.quality = degradeQualityBy(item.quality, 2);
} else {
item.quality = degradeQualityBy(item.quality, 4);
} }
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }

8
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -23,11 +23,15 @@ class GildedRoseTest {
Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 0)}), "Normal Item", -1, 0), Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 0)}), "Normal Item", -1, 0),
Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 10)}), "Normal Item", -1, 8), Arguments.of(new GildedRose(new Item[]{new Item("Normal Item", 0, 10)}), "Normal Item", -1, 8),
//1. Conjured item //2. Conjured item
//1.a Before sellIn //2.a Before sellIn
Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 10)}), "Conjured Mana Cake", 0, 8), Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 10)}), "Conjured Mana Cake", 0, 8),
Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 0)}), "Conjured Mana Cake", 0, 0), Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 1, 0)}), "Conjured Mana Cake", 0, 0),
//2.b after sellIn
Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 0, 0)}),"Conjured Mana Cake", -1, 0),
Arguments.of(new GildedRose(new Item[]{new Item("Conjured Mana Cake", 0, 10)}), "Conjured Mana Cake", -1, 6),
Arguments.of(new GildedRose(new Item[]{new Item("+5 Dexterity Vest", 10, 20)}), "+5 Dexterity Vest", 9, 19), Arguments.of(new GildedRose(new Item[]{new Item("+5 Dexterity Vest", 10, 20)}), "+5 Dexterity Vest", 9, 19),