OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 16:31:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract quality inc and decrease into private method

Browse Source
This commit is contained in:
Bjorn Misseghers 2021-04-06 20:21:13 +02:00
parent 8b94d335e8
commit 2fb5d2bc77
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -20,23 +20,23 @@ class GildedRose {
&& !currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { && !currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) {
if (currentItem.quality > MIN_QUALITY_LEVEL) { if (currentItem.quality > MIN_QUALITY_LEVEL) {
if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) { if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) {
currentItem.quality = currentItem.quality - 1; decreaseQuality(currentItem);
} }
} }
} else { } else {
if (currentItem.quality < MAX_QUALITY_LEVEL) { if (currentItem.quality < MAX_QUALITY_LEVEL) {
currentItem.quality = currentItem.quality + 1; increaseQuality(currentItem);
if (currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { if (currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) {
if (currentItem.sellIn < 11) { if (currentItem.sellIn < 11) {
if (currentItem.quality < MAX_QUALITY_LEVEL) { if (currentItem.quality < MAX_QUALITY_LEVEL) {
currentItem.quality = currentItem.quality + 1; increaseQuality(currentItem);
} }
} }
if (currentItem.sellIn < 6) { if (currentItem.sellIn < 6) {
if (currentItem.quality < MAX_QUALITY_LEVEL) { if (currentItem.quality < MAX_QUALITY_LEVEL) {
currentItem.quality = currentItem.quality + 1; increaseQuality(currentItem);
} }
} }
} }
@ -52,7 +52,7 @@ class GildedRose {
if (!currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) { if (!currentItem.name.equals(ITEM_BACKSTAGE_PASSES)) {
if (currentItem.quality > MIN_QUALITY_LEVEL) { if (currentItem.quality > MIN_QUALITY_LEVEL) {
if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) { if (!currentItem.name.equals(ITEM_SULFURAS_HAND_OF_RAGNAROS)) {
currentItem.quality = currentItem.quality - 1; decreaseQuality(currentItem);
} }
} }
} else { } else {
@ -60,10 +60,18 @@ class GildedRose {
} }
} else { } else {
if (currentItem.quality < MAX_QUALITY_LEVEL) { if (currentItem.quality < MAX_QUALITY_LEVEL) {
currentItem.quality = currentItem.quality + 1; increaseQuality(currentItem);
} }
} }
} }
} }
} }
private void decreaseQuality(Item item) {
item.quality = item.quality - 1;
}
private void increaseQuality(Item item) {
item.quality = item.quality + 1;
}
} }