OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-20 17:01:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: adding a updateItem method to keep the code dry

Browse Source
This commit is contained in:
pierre 2023-02-19 13:29:50 +01:00
parent 035e646326
commit 379648a572
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -12,13 +12,7 @@ class GildedRose {
if (!items[i].name.equals("Aged Brie") if (!items[i].name.equals("Aged Brie")
&& !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { && !items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { updateItem(items[i]);
items[i].quality = items[i].quality - 1;
if (items[i].name.equals("Conjured Mana Cake") && items[i].quality > 0) {
items[i].quality = items[i].quality - 1;
}
}
} }
} else { } else {
if (items[i].quality < 50) { if (items[i].quality < 50) {
@ -43,13 +37,7 @@ class GildedRose {
if (!items[i].name.equals("Aged Brie")) { if (!items[i].name.equals("Aged Brie")) {
if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { updateItem(items[i]);
items[i].quality = items[i].quality - 1;
if (items[i].name.equals("Conjured Mana Cake") && items[i].quality > 0) {
items[i].quality = items[i].quality - 1;
}
}
} }
} else { } else {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = items[i].quality - items[i].quality;
@ -62,4 +50,16 @@ class GildedRose {
} }
} }
} }
public void updateItem(Item item){
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1;
if (item.name.equals("Conjured Mana Cake") && item.quality > 0) {
item.quality = item.quality - 1;
}
}
}
} }