OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Inline unnecesary private method

Browse Source
This commit is contained in:
Bart Van der Plancken 2020-02-06 21:52:56 +01:00
parent 45aff46cba
commit 3e07a9abe9
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -22,26 +22,19 @@ class GildedRose {
} }
if (isEnhancingItem(item)) { if (isEnhancingItem(item)) {
int qualityOffset = determineQualityOffset(item); int qualityOffset = determineQualityOffset(item);
enhanceItem(item, qualityOffset); item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY);
} else { } else {
int qualityOffset = 1; int qualityOffset = 1;
if(item.sellIn <= 0) { if(item.sellIn <= 0) {
qualityOffset +=1; qualityOffset +=1;
} }
degradeItem(item,qualityOffset); item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset);
} }
updateSellInValue(item); updateSellInValue(item);
} }
} }
/**
* @param item
*/
private void degradeItem(Item item, int qualityOffset) {
item.quality = Integer.max(MIN_QUALITY, item.quality - qualityOffset);
}
/** /**
* @param item * @param item
* @return * @return
@ -58,13 +51,6 @@ class GildedRose {
return item.name.equals(GildedRose.AGED_BRIE) || item.name.equals(BACKSTAGE_PASSES); return item.name.equals(GildedRose.AGED_BRIE) || item.name.equals(BACKSTAGE_PASSES);
} }
/**
* @param item
*/
private void enhanceItem(Item item, int qualityOffset) {
item.quality = Integer.min(item.quality + qualityOffset, MAX_QUALITY);
}
/** /**
* @param item * @param item
* @return * @return