OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 15:31:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Modify conditional statment

Browse Source
This commit is contained in:
kitfbgh 2022-04-02 11:26:24 +08:00
parent d7a4efeef7
commit 468ff532ea
1 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
php/src/GildedRose.php
View File

@ -24,13 +24,7 @@ final class GildedRose
public function updateQuality(): void public function updateQuality(): void
{ {
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name !== 'Aged Brie' and $item->name !== 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Aged Brie' || $item->name === 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->quality > 0) {
if ($item->name !== 'Sulfuras, Hand of Ragnaros') {
$item->quality = $item->quality - 1;
}
}
} else {
if ($item->quality < 50) { if ($item->quality < 50) {
$item->quality = $item->quality + 1; $item->quality = $item->quality + 1;
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
@ -46,26 +40,34 @@ final class GildedRose
} }
} }
} }
} else {
if ($item->quality > 0) {
if ($item->name !== 'Sulfuras, Hand of Ragnaros') {
$item->quality = $item->quality - 1;
}
}
} }
if ($item->name !== 'Sulfuras, Hand of Ragnaros') { if ($item->name === 'Sulfuras, Hand of Ragnaros') {
} else {
$item->sellIn = $item->sellIn - 1; $item->sellIn = $item->sellIn - 1;
} }
if ($item->sellIn < 0) { if ($item->sellIn < 0) {
if ($item->name !== 'Aged Brie') { if ($item->name === 'Aged Brie') {
if ($item->name !== 'Backstage passes to a TAFKAL80ETC concert') { if ($item->quality < 50) {
$item->quality = $item->quality + 1;
}
} else {
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
$item->quality = $item->quality - $item->quality;
} else {
if ($item->quality > 0) { if ($item->quality > 0) {
if ($item->name !== 'Sulfuras, Hand of Ragnaros') { if ($item->name === 'Sulfuras, Hand of Ragnaros') {
} else {
$item->quality = $item->quality - 1; $item->quality = $item->quality - 1;
} }
} }
} else {
$item->quality = $item->quality - $item->quality;
}
} else {
if ($item->quality < 50) {
$item->quality = $item->quality + 1;
} }
} }
} }