OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code fixes

Browse Source 
fixed else if refractor in 2 places
fixed item.quality - item.quality to item.quality = 0
This commit is contained in:
Chamoda Ranasinghe 2024-01-16 02:36:57 +07:00
parent f6a3a6d718
commit 4dd7622f7a
No known key found for this signature in database
GPG Key ID: DE81C3C335B7CED3
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
TypeScript/app/gilded-rose.ts
View File

@ -30,8 +30,7 @@ export class GildedRose {
item.quality = item.quality - 1; item.quality = item.quality - 1;
} }
} }
} else { } else if (item.quality < MAX_ITEM_QUALITY) {
if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
if (item.name == ItemNames.BACKSTAGE_PASSES) { if (item.name == ItemNames.BACKSTAGE_PASSES) {
if (item.sellIn < 11) { if (item.sellIn < 11) {
@ -46,7 +45,6 @@ export class GildedRose {
} }
} }
} }
}
if (item.name != ItemNames.SULFURAS) { if (item.name != ItemNames.SULFURAS) {
item.sellIn = item.sellIn - 1; item.sellIn = item.sellIn - 1;
} }
@ -59,15 +57,13 @@ export class GildedRose {
} }
} }
} else { } else {
item.quality = item.quality - item.quality; item.quality = 0;
} }
} else { } else if (item.quality < MAX_ITEM_QUALITY) {
if (item.quality < MAX_ITEM_QUALITY) {
item.quality = item.quality + 1; item.quality = item.quality + 1;
} }
} }
} }
}
return this.items; return this.items;
} }