OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 15:31:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

add new class

Browse Source 
add new class to start wrapping all the methods
This commit is contained in:
Trobax 2022-11-23 17:17:42 +01:00
parent 0d3aefb6c8
commit 4e692bf70e
4 changed files with 25 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -7,8 +7,9 @@ class GildedRose {
this.items = items; this.items = items;
} }
public void updateInventory() { public void updateStorage() {
for (Item item : items) { for (Item item : items) {
new StrorageItem(item);
updateItem(item); updateItem(item);
} }
} }

9
Java/src/main/java/com/gildedrose/StrorageItem.java Normal file
View File

@ -0,0 +1,9 @@
package com.gildedrose;
public class StrorageItem {
private Item item;
public StrorageItem(Item item) {
this.item = item;
}
}

26
Java/src/test/java/com/gildedrose/GildedRoseTest.java
View File

@ -11,7 +11,7 @@ class GildedRoseTest {
void foo() { void foo() {
Item[] items = new Item[] { new Item("foo", 0, 0) }; Item[] items = new Item[] { new Item("foo", 0, 0) };
GildedRose app = new GildedRose(items); GildedRose app = new GildedRose(items);
app.updateInventory(); app.updateStorage();
assertEquals("foo", app.items[0].name); assertEquals("foo", app.items[0].name);
} }
@ -22,7 +22,7 @@ class GildedRoseTest {
final Item standardItem = new Item("spam", startingSellin, startingQuality); final Item standardItem = new Item("spam", startingSellin, startingQuality);
GildedRose app = new GildedRose(new Item[]{standardItem}); GildedRose app = new GildedRose(new Item[]{standardItem});
app.updateInventory(); app.updateStorage();
assertThat(standardItem.sellIn).isEqualTo(startingSellin - 1); assertThat(standardItem.sellIn).isEqualTo(startingSellin - 1);
assertThat(standardItem.quality).isEqualTo(startingQuality - 1); assertThat(standardItem.quality).isEqualTo(startingQuality - 1);
@ -34,7 +34,7 @@ class GildedRoseTest {
Item secondItem = new Item("Second Standard Item", 3, 2); Item secondItem = new Item("Second Standard Item", 3, 2);
GildedRose app = new GildedRose(new Item[]{firstItem, secondItem}); GildedRose app = new GildedRose(new Item[]{firstItem, secondItem});
app.updateInventory(); app.updateStorage();
assertThat(firstItem.sellIn).isEqualTo(4); assertThat(firstItem.sellIn).isEqualTo(4);
assertThat(firstItem.quality).isEqualTo(3); assertThat(firstItem.quality).isEqualTo(3);
@ -47,7 +47,7 @@ class GildedRoseTest {
Item item = new Item("Standard Item", -1, 6); Item item = new Item("Standard Item", -1, 6);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(4); assertThat(item.quality).isEqualTo(4);
} }
@ -57,7 +57,7 @@ class GildedRoseTest {
Item item = new Item("Standard Item", 1, 6); Item item = new Item("Standard Item", 1, 6);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(5); assertThat(item.quality).isEqualTo(5);
} }
@ -67,7 +67,7 @@ class GildedRoseTest {
Item item = new Item("Standard Item", 5, 1); Item item = new Item("Standard Item", 5, 1);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isZero(); assertThat(item.quality).isZero();
} }
@ -77,7 +77,7 @@ class GildedRoseTest {
Item item = new Item("First Standard Item", 4, 0); Item item = new Item("First Standard Item", 4, 0);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isZero(); assertThat(item.quality).isZero();
} }
@ -87,7 +87,7 @@ class GildedRoseTest {
Item item = new Item("Aged Brie", 5, 6); Item item = new Item("Aged Brie", 5, 6);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(7); assertThat(item.quality).isEqualTo(7);
} }
@ -97,7 +97,7 @@ class GildedRoseTest {
Item item = new Item("Aged Brie", 5, 49); Item item = new Item("Aged Brie", 5, 49);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(50); assertThat(item.quality).isEqualTo(50);
} }
@ -107,7 +107,7 @@ class GildedRoseTest {
Item item = new Item("Aged Brie", 0, 6); Item item = new Item("Aged Brie", 0, 6);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(8); assertThat(item.quality).isEqualTo(8);
} }
@ -117,7 +117,7 @@ class GildedRoseTest {
Item item = new Item("Aged Brie", 0, 50); Item item = new Item("Aged Brie", 0, 50);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(50); assertThat(item.quality).isEqualTo(50);
} }
@ -127,7 +127,7 @@ class GildedRoseTest {
Item item = new Item("Aged Brie", 5, 50); Item item = new Item("Aged Brie", 5, 50);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.quality).isEqualTo(50); assertThat(item.quality).isEqualTo(50);
} }
@ -137,7 +137,7 @@ class GildedRoseTest {
Item item = new Item("Sulfuras, Hand of Ragnaros", -1, 80); Item item = new Item("Sulfuras, Hand of Ragnaros", -1, 80);
GildedRose app = new GildedRose(new Item[]{item}); GildedRose app = new GildedRose(new Item[]{item});
app.updateInventory(); app.updateStorage();
assertThat(item.sellIn).isEqualTo(-1); assertThat(item.sellIn).isEqualTo(-1);
} }

2
Java/src/test/java/com/gildedrose/TexttestFixture.java
View File

@ -30,7 +30,7 @@ public class TexttestFixture {
System.out.println(item); System.out.println(item);
} }
System.out.println(); System.out.println();
app.updateInventory(); app.updateStorage();
} }
} }