OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-19 08:21:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Flattens if conditions

Browse Source
This commit is contained in:
shanmukhanath 2022-06-12 16:35:38 +05:30
parent 199c64de9a
commit 4f222d3481
1 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
python/gilded_rose.py
View File

@ -15,33 +15,33 @@ class GildedRose(object):
self.update_item_quality(item) self.update_item_quality(item)
def update_item_quality(self, item): def update_item_quality(self, item):
isExpired = item.sell_in < 0
doesDegradeQaulity = item.name != self.AGED_BRIE and item.name != self.BACKSTAGE_PASSES and item.name != self.SULFURAS
if item.name != self.AGED_BRIE and item.name != self.BACKSTAGE_PASSES: if doesDegradeQaulity:
if item.quality > 0: self.adjust_quality(item, - self.qualityIncrease)
if item.name != self.SULFURAS: if item.name == self.AGED_BRIE:
self.adjust_quality(item, - self.qualityIncrease) self.adjust_quality(item, self.qualityIncrease)
else:
if item.quality < 50: if item.name == self.BACKSTAGE_PASSES:
self.adjust_quality(item, self.qualityIncrease)
if item.sell_in < 11:
self.adjust_quality(item, self.qualityIncrease) self.adjust_quality(item, self.qualityIncrease)
if item.name == self.BACKSTAGE_PASSES: if item.sell_in < 6:
if item.sell_in < 11: self.adjust_quality(item, self.qualityIncrease)
self.adjust_quality(item, self.qualityIncrease)
if item.sell_in < 6:
self.adjust_quality(item, self.qualityIncrease)
if item.name != self.SULFURAS: if item.name != self.SULFURAS:
item.sell_in = item.sell_in - 1 item.sell_in = item.sell_in - 1
if item.sell_in < 0:
if item.name != self.AGED_BRIE:
if item.name != self.BACKSTAGE_PASSES: if isExpired:
if item.quality > 0: if doesDegradeQaulity:
if item.name != self.SULFURAS: self.adjust_quality(item, - self.qualityIncrease)
self.adjust_quality(item, - self.qualityIncrease) if item.quality == self.BACKSTAGE_PASSES:
else: item.quality = item.quality - item.quality
item.quality = item.quality - item.quality if item.quality == self.AGED_BRIE:
else: self.adjust_quality(item, self.qualityIncrease)
if item.quality < 50:
self.adjust_quality(item, self.qualityIncrease)
# Update the quality item value if the quality value is within the range 0 to 50 # Update the quality item value if the quality value is within the range 0 to 50
def adjust_quality(self, item, quality_increase_decrease): def adjust_quality(self, item, quality_increase_decrease):
@ -51,7 +51,7 @@ class GildedRose(object):
class Item: class Item:
def __init__(self, name, sell_in, quality): def __init__(self, name, sell_in, quality):
self.name = name self.name = name
self.sell_in = sell_in self.sell_in = sell_in