mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-02-15 22:41:30 +00:00
fix code smells
This commit is contained in:
parent
727d4b66c4
commit
67769ddd57
@ -16,14 +16,13 @@ class GildedRose {
|
||||
public void updateQuality() {
|
||||
for (int i = 0; i < items.length; i++) {
|
||||
reduceSellInItem(i);
|
||||
|
||||
if (isEspecialItem(items[i])) {
|
||||
valueItems(i);
|
||||
} else {
|
||||
devalueItems(i);
|
||||
}
|
||||
if (items[i].sellIn < 0) {
|
||||
qualityWhenDaysAreOver(i);
|
||||
alterQualityWhenDaysAreOver(i);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -46,7 +45,7 @@ class GildedRose {
|
||||
}
|
||||
}
|
||||
|
||||
private void qualityWhenDaysAreOver(int i) {
|
||||
private void alterQualityWhenDaysAreOver(int i) {
|
||||
if (items[i].name.equals(AGED_ITEM) && canIncreaseQuality(items[i].quality)) {
|
||||
increaseQuality(i);
|
||||
} else if (items[i].name.equals(BACKSTAGE_ITEM)) {
|
||||
|
||||
Loading…
Reference in New Issue
Block a user