OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix code smells

Browse Source
This commit is contained in:
Santiago Garcia 2020-09-29 17:55:12 -05:00
parent 727d4b66c4
commit 67769ddd57
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -16,14 +16,13 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
reduceSellInItem(i); reduceSellInItem(i);
if (isEspecialItem(items[i])) { if (isEspecialItem(items[i])) {
valueItems(i); valueItems(i);
} else { } else {
devalueItems(i); devalueItems(i);
} }
if (items[i].sellIn < 0) { if (items[i].sellIn < 0) {
qualityWhenDaysAreOver(i); alterQualityWhenDaysAreOver(i);
} }
} }
} }
@ -46,7 +45,7 @@ class GildedRose {
} }
} }
private void qualityWhenDaysAreOver(int i) { private void alterQualityWhenDaysAreOver(int i) {
if (items[i].name.equals(AGED_ITEM) && canIncreaseQuality(items[i].quality)) { if (items[i].name.equals(AGED_ITEM) && canIncreaseQuality(items[i].quality)) {
increaseQuality(i); increaseQuality(i);
} else if (items[i].name.equals(BACKSTAGE_ITEM)) { } else if (items[i].name.equals(BACKSTAGE_ITEM)) {