OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-20 08:51:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Extract more to bsp module

Browse Source
This commit is contained in:
Dan Holmes 2020-12-03 16:27:19 +00:00
parent 14dda486bf
commit 8b9bb79818
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
js-jasmine/src/backstage_pass_update.js
View File

@ -1,5 +1,17 @@
function getQualityChange(item) {
if (item.sellIn <= 0) {
return -item.quality;
} else if (item.sellIn <= 5) {
return 3;
} else if (item.sellIn <= 10) {
return 2;
} else {
return 1;
}
}
function isBackstagePass(item) { function isBackstagePass(item) {
return item.name.toLowerCase().match(/backstage pass/); return item.name.toLowerCase().match(/backstage pass/);
}; };
module.exports = { isBackstagePass } module.exports = { isBackstagePass, getQualityChange };

14
js-jasmine/src/shop.js
View File

@ -26,7 +26,7 @@ class Shop {
_getQualityChange(item) { _getQualityChange(item) {
if (bsp.isBackstagePass(item)) { if (bsp.isBackstagePass(item)) {
return this._getQualityChangeBackstagePass(item); return bsp.getQualityChange(item);
} else if (this._isAgedBrie(item)) { } else if (this._isAgedBrie(item)) {
return this._getQualityChangeAgedBrie(item); return this._getQualityChangeAgedBrie(item);
} else if (this._isSulfuras(item)) { } else if (this._isSulfuras(item)) {
@ -52,18 +52,6 @@ class Shop {
} }
} }
_getQualityChangeBackstagePass(item) {
if (item.sellIn <= 0) {
return -item.quality;
} else if (item.sellIn <= 5) {
return 3;
} else if (item.sellIn <= 10) {
return 2;
} else {
return 1;
}
}
_getQualityChangeAgedBrie(item) { _getQualityChangeAgedBrie(item) {
if (item.sellIn <= 0) { if (item.sellIn <= 0) {
return 2; return 2;