OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Duplicated Code] extract to function

Browse Source
This commit is contained in:
jiajun.chou 2020-08-13 21:28:45 +08:00
parent c4f6bc4d2a
commit 9f2e89713f
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -28,13 +28,7 @@ class GildedRose {
} }
} }
} else { } else {
if (items[i].quality > 0) { caculateQuilaty_without_Sulfuras(i);
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
} else {
items[i].quality = items[i].quality - 1;
}
}
} }
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
@ -52,6 +46,14 @@ class GildedRose {
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
items[i].quality = items[i].quality - items[i].quality; items[i].quality = items[i].quality - items[i].quality;
} else { } else {
caculateQuilaty_without_Sulfuras(i);
}
}
}
}
}
private void caculateQuilaty_without_Sulfuras(int i) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
@ -61,7 +63,3 @@ class GildedRose {
} }
} }
} }
}
}
}
}