OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-18 07:51:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: moving up guard clause for TAFKAL80ETC Concert if quality is inferior to 50

Browse Source
This commit is contained in:
pierre 2023-02-18 17:34:19 +01:00
parent f2b170a736
commit a81faa5f29
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -21,20 +21,18 @@ class GildedRose {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (items[i].sellIn < 11) { if (items[i].sellIn < 11 && items[i].quality < 50) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
}
} }
if (items[i].sellIn < 6) { if (items[i].sellIn < 6 && items[i].quality < 50) {
if (items[i].quality < 50) {
items[i].quality = items[i].quality + 1; items[i].quality = items[i].quality + 1;
} }
} }
} }
} }
}
if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) {
items[i].sellIn = items[i].sellIn - 1; items[i].sellIn = items[i].sellIn - 1;