OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-14 06:01:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: remove nested if condition

Browse Source
This commit is contained in:
EmanFateen 2025-11-22 23:21:44 +02:00
parent 99de845aa5
commit d80e4d5840
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
php/src/GildedRose.php
View File

@ -18,14 +18,14 @@ final class GildedRose
public function updateQuality(): void public function updateQuality(): void
{ {
foreach ($this->items as $item) { foreach ($this->items as $item) {
if ($item->name === 'Sulfuras, Hand of Ragnaros') { if ($item->name === 'Sulfuras, Hand of Ragnaros')
continue; continue;
}
if ($item->name === 'Aged Brie') { if ($item->name === 'Aged Brie') {
$item->quality = min(50, ++$item->quality); $item->quality = min(50, ++$item->quality);
} else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') { } else if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') {
if ($item->sellIn < 6) { if ($item->sellIn <= 5) {
$updatedQuality = $item->quality + 3; $updatedQuality = $item->quality + 3;
$item->quality = min(50, $updatedQuality); $item->quality = min(50, $updatedQuality);
} else if ($item->sellIn <= 10) { } else if ($item->sellIn <= 10) {
@ -39,10 +39,9 @@ final class GildedRose
$item->sellIn--; $item->sellIn--;
if ($item->sellIn < 0) { if ($item->sellIn < 0 && $item->name === 'Backstage passes to a TAFKAL80ETC concert')
if ($item->name === 'Backstage passes to a TAFKAL80ETC concert') $item->quality = 0;
$item->quality = 0;
}
} }
} }
} }