OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-16 06:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Refactoring :Separated expired item quality check based on item type to improve readability.

Browse Source
This commit is contained in:
lekshmysasidhar 2023-03-31 10:39:05 +02:00
parent e5625734e5
commit f576dd8f49
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Java/src/main/java/com/gildedrose/GildedRose.java
View File

@ -60,18 +60,25 @@ class GildedRose {
if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) { if (!item.name.equals("Backstage passes to a TAFKAL80ETC concert")) {
if (item.quality > 0) { if (item.quality > 0) {
if (!item.name.equals("Sulfuras, Hand of Ragnaros")) { if (!item.name.equals("Sulfuras, Hand of Ragnaros")) {
item.quality = item.quality - 1; updateQualityForExpiredItemNormal(item);
} }
} }
} else { } else {
item.quality = item.quality - item.quality; updateQualityForExpiredItemBackstagePasses(item);
} }
} else { } else {
addQualityWhenWithInLimit(item); addQualityWhenWithInLimit(item);
} }
} }
} }
private void updateQualityForExpiredItemBackstagePasses(Item item) {
item.quality = 0;
}
private void updateQualityForExpiredItemNormal(Item item) {
item.quality--;
}
private void updateSellInDays(Item item) { private void updateSellInDays(Item item) {
item.sellIn--; item.sellIn--;