OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-17 23:41:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fully working refactor (all tests pass).

Browse Source
This commit is contained in:
alexmerryman 2020-02-27 22:34:21 -06:00
parent 6218eea266
commit faa4859dc5
1 changed files with 28 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

95
python/gilded_rose.py
View File

@ -7,102 +7,63 @@ class GildedRose(object):
def update_quality(self): def update_quality(self):
for item in self.items: for item in self.items:
# Set default parameters
sell_in_rate = 1
quality_rate = 1
quality_sign = -1
# Once the sell by date has passed, Quality degrades twice as fast # Once the sell by date has passed, Quality degrades twice as fast
if item.sell_in < 0: if item.sell_in <= 0:
quality_rate = 2 quality_rate = 2
# The Quality of an item is never negative
if item.quality < 0:
item.quality = 0
# "Sulfuras", being a legendary item, never has to be sold or decreases in Quality # "Sulfuras", being a legendary item, never has to be sold or decreases in Quality
if item.name == "Sulfuras, Hand of Ragnaros": if item.name == "Sulfuras, Hand of Ragnaros":
sell_in_rate = 0 sell_in_rate = 0
quality_rate = 0 quality_rate = 0
quality_inc_dec = 0 quality_sign = 0
elif item.name == "Aged Brie": elif item.name == "Aged Brie":
sell_in_rate = 1
# "Aged Brie" actually increases in Quality the older it gets # "Aged Brie" actually increases in Quality the older it gets
quality_inc_dec = 1 quality_sign = 1
elif item.name == "Backstage passes to a TAFKAL80ETC concert": elif item.name == "Backstage passes to a TAFKAL80ETC concert":
sell_in_rate = 1
# Quality drops to 0 after the concert # Quality drops to 0 after the concert
if item.sell_in < 0: if item.sell_in <= 0:
item.quality -= item.quality item.quality -= item.quality
quality_sign = 0
# Quality increases by 3 when there are 5 days or less # Quality increases by 3 when there are 5 days or less
elif item.sell_in < 6: elif item.sell_in <= 5:
quality_rate = 3 quality_rate = 3
# "Backstage passes..." increases in quality # "Backstage passes..." increases in quality
quality_inc_dec = 1 quality_sign = 1
# Quality increases by 2 when there are 10 days or less # Quality increases by 2 when there are 10 days or less
elif item.sell_in < 11: elif item.sell_in <= 10:
quality_rate = 2 quality_rate = 2
# "Backstage passes..." increases in quality # "Backstage passes..." increases in quality
quality_inc_dec = 1 quality_sign = 1
elif item.name == "Conjured Mana Cake":
sell_in_rate = 1
quality_rate = 1
quality_inc_dec = -1
else:
quality_sign = 1
elif item.name == "Conjured Mana Cake":
if item.sell_in < 0: if item.sell_in < 0:
quality_rate = 2 quality_rate = 2
# Set default values for any unknown items
else:
sell_in_rate = 1
quality_rate = 1
quality_inc_dec = -1
item.sell_in -= sell_in_rate item.sell_in -= sell_in_rate
item.quality += (quality_inc_dec*quality_rate) item.quality += (quality_sign*quality_rate)
# CONDITIONS THAT ARE ALWAYS TRUE FOR EVERY ITEM
# The Quality of an item is never negative
if item.quality < 0:
item.quality = 0
# No items' quality can exceed 50, except 'Sulfuras, Hand of Ragnaros'
if item.quality > 50 and item.name != "Sulfuras, Hand of Ragnaros": if item.quality > 50 and item.name != "Sulfuras, Hand of Ragnaros":
item.quality = 50 item.quality = 50
# # item.name is something other than "Aged Brie" or "Backstage passes to a TAFKAL80ETC concert"
# if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert":
# if item.quality > 0:
#
# # item.name is something other than "Sulfuras, Hand of Ragnaros"
# if item.name != "Sulfuras, Hand of Ragnaros":
# item.quality -= 1
#
# # item.name == "Aged Brie" OR "Backstage passes to a TAFKAL80ETC concert"
# else:
# if item.quality < 50:
# item.quality += 1
# if item.name == "Backstage passes to a TAFKAL80ETC concert":
# if item.sell_in < 11:
# if item.quality < 50:
# item.quality += 1
# if item.sell_in < 6:
# if item.quality < 50:
# item.quality += 1
#
#
# if item.name != "Sulfuras, Hand of Ragnaros":
# item.sell_in -= 1
#
#
# if item.sell_in < 0:
# if item.name != "Aged Brie":
# if item.name != "Backstage passes to a TAFKAL80ETC concert":
# if item.quality > 0:
# if item.name != "Sulfuras, Hand of Ragnaros":
# item.quality -= 1
# else:
# item.quality -= item.quality
# else:
# if item.quality < 50:
# item.quality += 1
class Item: class Item:
def __init__(self, name, sell_in, quality): def __init__(self, name, sell_in, quality):
self.name = name self.name = name