OpenSource/GildedRose-Refactoring-Kata
1
0 Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-10-13 17:49:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

added (no) for negative path in if-statements

Browse Source
This commit is contained in:
Michel Grootjans committed 2019-12-30 13:08:06 +01:00
1 parent 632a6768eb
commit ff06861ab7
7 files changed
+46 -2
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

plantuml/gilded-rose.puml
+14 -1
View File
@@ -10,7 +10,9 @@ if (not "Aged Brie" and not "Backstage passes to a TAFKAL80ETC concert") then (y
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
@@ -19,19 +21,26 @@ else (no)
if (sell in < 11) then (yes) if (sell in < 11) then (yes)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
else (no)
endif endif
if (sell in < 6) then (yes) if (sell in < 6) then (yes)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
else (no)
endif endif
else (no)
endif endif
else (no)
endif endif
endif endif
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower sell in with 1
else (no)
endif endif
if (sell in < 0) then (yes) if (sell in < 0) then (yes)
@@ -40,7 +49,9 @@ if (sell in < 0) then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
-lower quality with quality -lower quality with quality
@@ -48,8 +59,10 @@ if (sell in < 0) then (yes)
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
else (no)
endif endif
stop stop
plantuml/history/02_sell-by-passed.puml
+1 -1
View File
@@ -7,11 +7,11 @@ note left
end note end note
-lower quality with 1 -lower quality with 1
-lower sell in with 1 -lower sell in with 1
if (sell in < 0) then (yes) if (sell in < 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
stop stop
plantuml/history/03_quality-never-negative.puml
+3
View File
@@ -8,6 +8,7 @@ end note
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
-lower sell in with 1 -lower sell in with 1
@@ -15,7 +16,9 @@ endif
if (sell in < 0) then (yes) if (sell in < 0) then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
stop stop
plantuml/history/04_aged-brie.puml
+3
View File
@@ -9,6 +9,7 @@ end note
if (not "Aged Brie") then (yes) if (not "Aged Brie") then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no) else (no)
-increase quality with 1 -increase quality with 1
@@ -20,10 +21,12 @@ if (sell in < 0) then (yes)
if (not "Aged Brie") then (yes) if (not "Aged Brie") then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no) else (no)
-increase quality with 1 -increase quality with 1
endif endif
else (no)
endif endif
stop stop
plantuml/history/05_quality-max-50.puml
+4
View File
@@ -9,10 +9,12 @@ end note
if (not "Aged Brie") then (yes) if (not "Aged Brie") then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
@@ -22,10 +24,12 @@ if (sell in < 0) then (yes)
if (not "Aged Brie") then (yes) if (not "Aged Brie") then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
endif endif
plantuml/history/06_sulfuras.puml
+8
View File
@@ -10,16 +10,20 @@ if (not "Aged Brie") then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower sell in with 1 -lower sell in with 1
else (no)
endif endif
if (sell in < 0) then (yes) if (sell in < 0) then (yes)
@@ -27,13 +31,17 @@ if (sell in < 0) then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
else (no)
endif endif
stop stop
plantuml/history/07_backstage-passes.puml
+13
View File
@@ -10,7 +10,9 @@ if (not "Aged Brie" and not "Backstage passes to a TAFKAL80ETC concert") then (y
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
@@ -19,19 +21,26 @@ else (no)
if (sell in < 11) then (yes) if (sell in < 11) then (yes)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
else (no)
endif endif
if (sell in < 6) then (yes) if (sell in < 6) then (yes)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
else (no)
endif endif
else (no)
endif endif
else (no)
endif endif
endif endif
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower sell in with 1 -lower sell in with 1
else (no)
endif endif
if (sell in < 0) then (yes) if (sell in < 0) then (yes)
@@ -40,7 +49,9 @@ if (sell in < 0) then (yes)
if (quality > 0) then (yes) if (quality > 0) then (yes)
if (not "Sulfuras, Hand of Ragnaros") then (yes) if (not "Sulfuras, Hand of Ragnaros") then (yes)
-lower quality with 1 -lower quality with 1
else (no)
endif endif
else (no)
endif endif
else (no) else (no)
-lower quality with quality -lower quality with quality
@@ -48,8 +59,10 @@ if (sell in < 0) then (yes)
else (no) else (no)
if (quality < 50) then (yes) if (quality < 50) then (yes)
-increase quality with 1 -increase quality with 1
else (no)
endif endif
endif endif
else (no)
endif endif
stop stop