Chamoda Ranasinghe
6109899ada
added CONJURED_CAKE key to ItemNames constant
2024-01-16 03:53:34 +07:00
Chamoda Ranasinghe
dc0af40495
cleared updateNormalItem method and asserted
2024-01-16 03:52:03 +07:00
Chamoda Ranasinghe
ddae445fec
cleared the updateSulfurasItem without affecting the test results
2024-01-16 03:45:48 +07:00
Chamoda Ranasinghe
ccf3cc6166
cleaned up updateSulfurasItem
...
asserted item name ItemNames.SULFURAS
2024-01-16 03:38:09 +07:00
Chamoda Ranasinghe
7577596171
cleaned up updateBackstagePassesItem method
...
asserted ItemNames.BACKSTAGE_PASSES
2024-01-16 03:33:11 +07:00
Chamoda Ranasinghe
98b400604e
cleaned up updateAgedBrieItem method
...
assert AGED_BREE key
2024-01-16 03:20:58 +07:00
Chamoda Ranasinghe
5c9f3822a2
added 4 individual private methods to update each item based on name
...
replicated main business logic to all 4 functions (can individually clean each function afterwards)
added a switch statement in the main loop to call private methods
2024-01-16 03:15:20 +07:00
Chamoda Ranasinghe
4dd7622f7a
Code fixes
...
fixed else if refractor in 2 places
fixed item.quality - item.quality to item.quality = 0
2024-01-16 02:36:57 +07:00
Chamoda Ranasinghe
f6a3a6d718
added MAX_ITEM_QUALITY in constants file and referred it
2024-01-16 02:30:10 +07:00
Chamoda Ranasinghe
e44c0a1d18
created const file and added ItemNames constant obj to maintain a key against each item name
2024-01-16 02:25:45 +07:00
Chamoda Ranasinghe
aeae3bbdc3
replaced main for loop in updateQuality method with for.. of
2024-01-16 02:10:34 +07:00
Chamoda Ranasinghe
dc038c3f11
removed approval should foo 1 from jest snapshot
2024-01-16 02:08:28 +07:00
Chamoda Ranasinghe
5d3ffc9223
Prepare test files to make sure Approval testing before refactoring
...
fixed failing unit test in jest/gilded-rose.spec.ts
deleted "should foo" test case from approvals.spec.ts
generated jest snapshot file (approvals.spec.ts.snap)
2024-01-16 02:04:18 +07:00
Peter Kofler
4bfda69d39
Merge pull request #515 from bronsonmcn/ruby-fix
...
doc - update command to run ruby tests
2024-01-07 14:47:23 +01:00
Bronson McNaughton
1bbc3b408a
doc - update command to run ruby tests
2024-01-07 12:09:21 +13:00
Peter Kofler
31bef1d837
Merge pull request #514 from nitsanavni/jq-simplify
...
jq: simplify
2024-01-06 22:38:30 +01:00
Peter Kofler
39091d3b65
Merge pull request #513 from nitsanavni/bash
...
bash: simplify texttest fixture
2024-01-06 22:33:31 +01:00
Nitsan Avni
d5b430fde9
- r jq: jaq -> jq, rm foreach
2024-01-05 09:21:12 +01:00
Nitsan Avni
dc652d4d09
. t bash/texttest_fixture.sh temp file -> variable
2024-01-05 09:11:57 +01:00
Emily Bache
a1e48be19f
Merge pull request #509 from nitsanavni/bash
...
bash
2023-12-28 08:27:57 +00:00
Nitsan Avni
6223bf9919
- F more compact
2023-12-26 18:09:52 +01:00
Nitsan Avni
7658124173
gilded_rose.sh: closer to original
2023-12-26 12:27:11 +01:00
Nitsan Avni
887ad0b60d
. d README: update field delimiter
2023-12-23 19:46:03 +01:00
Nitsan Avni
4490aaa5fd
- t failing unit test
2023-12-23 18:18:38 +01:00
Nitsan Avni
56ca5bf411
- t verify results
2023-12-23 17:56:14 +01:00
Nitsan Avni
9039daa7be
. d README.md notes
2023-12-23 17:29:46 +01:00
Nitsan Avni
bee8f54440
bash: initial impl
2023-12-23 17:26:19 +01:00
Emily Bache
fb9960b1f3
Merge pull request #506 from debashisbiswas/fix-requirements-link
...
Fix link to requirements
2023-12-14 07:05:44 +00:00
Debashis Biswas
6ab4336a22
Fix link to requirements
2023-12-13 11:15:41 -07:00
Emily Bache
fa212ef9aa
Merge pull request #505 from VioletaCalvo/doc/markdown-for-ensglish-requirements
...
doc: use markdown for english requirements
2023-12-11 07:00:28 +00:00
Violeta
4ef9d9b019
doc: use markdown for english requirements
2023-12-08 21:13:27 +01:00
Peter Kofler
318218e3bc
Merge branch 'nim'
2023-12-07 13:12:37 +01:00
Peter Kofler
77a444b600
Standard ignores for Nim.
2023-12-07 13:07:29 +01:00
Peter Kofler
ab84d1696c
Replace complete test with sample test.
2023-12-07 13:07:18 +01:00
Emily Bache
2e30c563d8
Merge pull request #498 from codecop/master
...
Approval tests starting points for PHP and TS/Jest.
2023-11-30 07:10:49 +00:00
Peter Kofler
c83be7b8f4
sourceMap must be true for coverage to work with correct line numbers.
2023-11-29 12:13:35 +01:00
Peter Kofler
d9f80abd06
TS: Add an Approval base test similar to Java-Approvals and CS-xunit-verify using Jest Snapshot.
2023-11-29 12:13:35 +01:00
Peter Kofler
2a96f34022
Do not commit the lock file.
2023-11-29 12:13:35 +01:00
Peter Kofler
4d5ca7b311
PHP: Add an Approval base test similar to Java-Approvals and CS-xunit-verify.
2023-11-29 12:13:35 +01:00
Emily Bache
7d758b5dc0
Merge pull request #497 from ronheywood/thirtyDaysTests
...
Tests named 30 days are run over 30 days
2023-11-28 09:00:44 +00:00
Ron Heywood
9fd97e0fcb
Tests named 30 days are run over 30 days
2023-11-28 08:46:04 +00:00
Emily Bache
9c5090521c
Update README.md
...
add link to gilded rose solution in Java
2023-11-22 09:46:36 +01:00
Emily Bache
5fb60271e2
Merge pull request #495 from schlessera/fix/php-remove-final-from-item-class
...
[PHP] Remove final keyword from Item class
2023-11-14 09:35:35 +00:00
Alain Schlesser
c64b2faf74
Remove final keyword from Item class
2023-11-14 09:14:39 +00:00
emily
d462c36618
remove unneeded files
2023-11-08 13:48:45 +01:00
emily
ce70beb469
Add settings for the C version
2023-11-08 13:44:42 +01:00
Typist
a2758b2183
added cmocka version
2023-11-08 12:38:42 +00:00
Emily Bache
3da2d5e046
Merge pull request #492 from ibaiimaz/main
...
Add Basque (Euskara) requirements translation
2023-11-08 06:35:11 +00:00
ibai imaz
70951455f0
Add Basque (Euskara) requirements translation
2023-11-07 17:25:00 +01:00
emily
4ffad014c6
Fix Python documentation
2023-11-03 16:56:46 +01:00
