@arik
68ee4cc4cd
Update GildedRose.cs
...
In this refactored version, I've made the following changes:
Changed the name of the private member variable to use camelCase naming convention and added a "readonly" keyword to make it immutable.
Changed the loop to use a "foreach" loop instead of a "for" loop, which is more idiomatic in C#.
Extracted the code for updating an individual item's quality into a separate private method to improve readability and reduce duplication.
Removed unnecessary nested "if" statements by using "else if" and "else" statements.
Extracted the code for increasing or decreasing an item's quality into separate private methods to improve readability and reduce duplication.
Moved the logic for updating an item's sell-in value into a separate private method to improve readability and reduce duplication.
2023-04-24 02:00:56 +03:00
Emily Bache
5a4e92199b
Merge pull request #402 from claresudbery/csharp-approval-fixes
...
Csharp approval fixes
2023-04-11 13:35:32 +02:00
Clare Sudbery
8d30f5efce
Remove approved.txt, for consistency with rest of repo
2023-04-10 11:40:45 +01:00
Clare Sudbery
8d0e82c2a6
Add default valid approved.txt to csharpcore
2023-04-08 14:55:45 +01:00
Clare Sudbery
588dbed420
Add approval test to csharpcore
2023-04-08 14:55:23 +01:00
Clare Sudbery
8dee58f73d
Ignore received.txt
2023-04-08 14:54:20 +01:00
Clare Sudbery
416b299856
Add Nuget packages needed for approval tests
2023-04-08 14:35:31 +01:00
Clare Sudbery
11569e0c0f
Test 31 days instead of 2
2023-04-08 14:21:07 +01:00
Emily Bache
227729512d
Merge pull request #417 from dmcg/master
...
Update versions in Kotlin variant, and use List rather than Array
2023-02-28 07:46:43 +01:00
Duncan McGregor
bce30ba386
Use List in place of Array
2023-02-27 22:32:10 +00:00
Duncan McGregor
054a7e18a4
Upgrade Kotlin to 1.8.10 and JUnit to 5.9.2
2023-02-27 22:30:45 +00:00
Emily Bache
2d115146eb
Merge pull request #415 from Gnuk/add-vitest
...
Add vitest inside TypeScript
2023-02-22 13:05:43 +01:00
Anthony Rey
95a5db2080
Add vitest inside TypeScript
2023-02-22 11:33:47 +01:00
Emily Bache
820e796fd8
Merge pull request #405 from nitsanavni/add-ci
...
add ci - start with jq
2023-02-08 08:30:44 +01:00
Nitsan Avni
8ee93709a5
jq ci: compare to 30 days texttest stdout
2023-02-07 17:13:45 +00:00
Nitsan Avni
e7545c322e
back to green, rename job
2023-02-07 17:12:18 +00:00
Nitsan Avni
6f17a85b91
intentionally fail the ci
2023-02-07 17:12:18 +00:00
Nitsan Avni
714d60b092
ci: test texttest result
2023-02-07 17:12:18 +00:00
Nitsan Avni
f982992850
diff action
2023-02-07 17:12:18 +00:00
Nitsan Avni
6527ea8bc3
add jq.yml workflow
2023-02-07 17:12:18 +00:00
Emily Bache
0fa2c2e623
Merge pull request #404 from nitsanavni/jq
...
add jq translation
2023-02-07 16:10:27 +01:00
Nitsan Avni
9a2736d267
use foreach for extra indentation
2023-02-07 08:35:39 +00:00
Nitsan Avni
9abe955027
add jq translation
2023-02-06 22:41:03 +00:00
Clare Sudbery
bacb1d9394
Add initial source of truth for C# approvals
2023-02-01 16:05:11 +00:00
Clare Sudbery
7700d349c3
Comment out C# texttest config by default
2023-02-01 16:03:04 +00:00
Clare Sudbery
f8a87ce507
Fix texttest config to work for csharp
2023-02-01 16:01:52 +00:00
emily
100fb3620a
remove dead better code hub
2023-01-16 08:19:13 +01:00
emily
d7b0cefc1a
remove BetterCode Hub, since it's no longer working. Improve info on TextTest.
2023-01-16 08:17:49 +01:00
Emily Bache
54cf2e5da8
Merge pull request #396 from JasonMoon95/patch-1
...
Update GildedRoseRequirements_kr.md
2023-01-13 14:44:04 +01:00
Seungje Mun
58ec0e4bee
Update GildedRoseRequirements_kr.md
...
10days or less can be translated to "10일 부터는".
2023-01-12 14:08:50 +09:00
Emily Bache
c6040ed788
Merge pull request #393 from Pen-y-Fan/php8
...
Bump to PHP 8.0+
2023-01-09 08:41:09 +01:00
Pen-y-Fan
081c69b864
Bump to PHP 8.0+
...
PHP 7.4 was end of life November 2022, it's time to bump to PHP 8 standard 🎉
- updated starting code to PHP 8 standard
- upgraded tooling (code quality, static analysis) to the latest versions
- tested with PHP 8.0, 8.1 and 8.2
- the fixture is working
- the example test is failing, as expected
- code quality is as expected
- static analysis is ok
2023-01-07 17:19:35 +00:00
Emily Bache
f7a3312e6b
Merge pull request #389 from hdeweirdt/main
...
Fix link to original description of the kata
2023-01-03 11:02:54 +01:00
Harm De Weirdt
415a394523
Fix link to original description of the kata
2022-12-28 15:58:43 +01:00
Emily Bache
7397b893f9
Merge pull request #385 from adericbourg/fix-blog-article-link
...
Fix "Why Most Solutions to Gilded Rose Miss The Bigger Picture" article link
2022-12-07 13:15:44 +01:00
emily
054da34a92
update .net version
2022-12-07 08:23:51 +01:00
Alban Dericbourg
e56289edfd
Fix "Why Most Solutions to Gilded Rose Miss The Bigger Picture" article link
...
Signed-off-by: Alban Dericbourg <alban.dericbourg@blablacar.com>
2022-12-06 15:56:34 +01:00
emily
ed4c9f9d62
make the gradle task for texttest slightly easier to use
2022-12-02 08:10:07 +01:00
Emily Bache
76e8590d6b
Merge pull request #384 from anirudh2/main
...
Fix Item parametric type
2022-11-29 11:49:40 +01:00
Anirudh
d1010005e5
Fix Item parametric type
2022-11-28 18:31:04 -08:00
Emily Bache
f8612a54a7
Merge pull request #383 from anirudh2/main
...
Add Julia Implementation
2022-11-28 13:44:53 +01:00
Anirudh
461e38e134
Julia implementation of the Gilded Rose kata
2022-11-28 01:00:21 -08:00
Emily Bache
0aab1b9ade
Merge pull request #382 from nitsanavni/java-text-test
...
Java: run text fixture from cli
2022-11-28 08:08:59 +01:00
Nitsan Avni
bd93f794bf
Java: run text fixture from cli
2022-11-27 16:14:50 +00:00
Emily Bache
ac8fce7557
Merge pull request #374 from ZeKap/patch-1
...
removed a word that didn't mean anything in the sentence in french
2022-11-10 09:05:22 +01:00
Kap
e8b4d95519
removed a word that didn't mean anything in the sentence in french
...
Now it's understandable
2022-11-07 09:31:27 +01:00
Emily Bache
878f2da3aa
Merge pull request #366 from Chemaclass/php/update-approvals-dependency
...
Bugfix: Update approvals php dependency
2022-10-12 15:43:45 +02:00
Emily Bache
e1e3c990f2
Merge pull request #367 from Chemaclass/php/update-phptan-max-level
...
Update level: max in phpstan.neon
2022-10-10 11:20:47 +02:00
Jose Maria Valera Reales
86fd140c4d
Update level:max in phpstan.neon
2022-10-07 10:06:58 +02:00
Jose Maria Valera Reales
07962c0803
Bugfix: Update approvals php dependency
2022-10-07 10:01:01 +02:00
