OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 22:41:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
531 Commits 1 Branch 0 Tags 39 MiB
9eb17f67da
Commit Graph

531 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Holmes
9eb17f67da Extract min quality checks 2020-12-03 14:40:22 +00:00
Dan Holmes
8038e6fb07 Max quality magic number 2020-12-03 14:34:55 +00:00
Dan Holmes
5eb160578e Extract checking max quality 2020-12-03 14:33:52 +00:00
Dan Holmes
bb67302d3a Extract _updateSellIn 2020-12-03 14:30:34 +00:00
Dan Holmes
cde87568f5 Extract updating individual item 2020-12-03 14:17:22 +00:00
Dan Holmes
8506d6e52b Group tests by item 2020-12-03 14:08:47 +00:00
Dan Holmes
1fb84b5bb2 Add tests for backstage passes 2020-12-03 14:02:20 +00:00
Dan Holmes
54e6f1b3d0 Add test for Sulfuras 2020-12-03 13:56:31 +00:00
Dan Holmes
a78885163c Add test for max quality 2020-12-03 13:53:23 +00:00
Dan Holmes
2cc2e0b1ab Add test for aged brie 2020-12-03 13:51:23 +00:00
Dan Holmes
1db637e963 Add test for aged brie 2020-12-03 13:50:05 +00:00
Dan Holmes
7b702676d5 Refactor tests 2020-12-03 13:47:26 +00:00
Dan Holmes
d5d00f41e8 Add test: When sell by passed, quality degrades by 2 2020-12-03 13:37:49 +00:00
Dan Holmes
4639d18db0 Add test: decreases quality by 1 2020-12-03 13:33:57 +00:00
Dan Holmes
e72f1de3af Add test: decreases sellIn by 1 2020-12-03 12:25:05 +00:00
Dan Holmes
75ef572dfa Refactor test descriptions 2020-12-03 12:04:34 +00:00
Dan Holmes
126208a692 Change file name for shop class 2020-12-03 12:02:27 +00:00
Dan Holmes
f9f3bb2187 Seperate item class to seperate file 2020-12-03 12:00:41 +00:00
Dan Holmes
51316a82c5 Mock item 2020-12-03 12:00:23 +00:00
Dan Holmes
92b6f1df15 Fix and pass first test 2020-12-03 11:52:38 +00:00
Emily Bache
e2c5826e71
Merge pull request #184 from ag4ta/change-line-separator 
Unify line separator in ruby example
 2020-09-27 08:50:29 +02:00
Agata Werszler
50daf3f025 Change line separator from CRLF to LF 2020-09-25 16:45:40 +02:00
Emily Bache
5ed37f4be5
Merge pull request #182 from mebusw/patch-2 
Update some words with explanation for paronomasia
 2020-09-25 08:33:11 +02:00
Jacky Shen
b713f7370d
Update GildedRoseRequirements_zh.txt 2020-09-25 13:05:39 +08:00
Emily Bache
a8dd468300
Merge pull request #179 from emilybache/dependabot/composer/php/symfony/http-kernel-5.1.5 
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php
 2020-09-08 14:51:16 +00:00
Emily Bache
b4a6bc2445
Merge pull request #178 from emilybache/dependabot/npm_and_yarn/js-jest/yargs-parser-13.1.2 
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest
 2020-09-08 14:47:05 +00:00
dependabot[bot]
9c42d32cf4
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php 
Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 5.0.8 to 5.1.5.
- [Release notes](https://github.com/symfony/http-kernel/releases)
- [Changelog](https://github.com/symfony/http-kernel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/http-kernel/compare/v5.0.8...v5.1.5)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:27:13 +00:00
dependabot[bot]
e5d807ebeb
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest 
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:26:39 +00:00
Emily Bache
99703481d7
Merge pull request #177 from emilybache/dependabot/npm_and_yarn/js-jest/handlebars-4.7.6 
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest
 2020-09-08 11:34:41 +00:00
dependabot[bot]
8140c13575
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.7.6)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-07 14:24:39 +00:00
Emily Bache
1c94a43a2d
Merge pull request #176 from olivierperez/fix/adjust-fr-requirements 
Adjust a bit French requirements
 2020-09-07 13:46:10 +00:00
Olivier PEREZ
e5c0d2653c Adjust a bit French description 2020-09-06 16:00:37 +02:00
Emily Bache
94b6e7a1e8
Merge pull request #174 from wpanas/upgrade_kotlin 
Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6
 2020-08-21 11:12:02 +00:00
wpanas
cce7b6381f Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6 2020-08-20 14:44:45 +02:00
Emily Bache
cd4e977616
Merge pull request #171 from nihonbuson/master 
Create GildedRoseRequirements_jp.md
 2020-08-17 05:50:10 +00:00
nihonbuson
30d1966bbe
Update GildedRoseRequirements_jp.md 
改行を変更した。
 2020-08-17 10:47:34 +09:00
nihonbuson
936c96524b
Create GildedRoseRequirements_jp.md 
日本語訳を作成
 2020-08-17 10:46:24 +09:00
Emily Bache
28443f97b2
Merge pull request #167 from mergermarket/ts-texttest 
Create texttest settings for TypeScript version
 2020-07-27 10:32:26 +02:00
Emily Bache
ef5d1ffb9f
Merge pull request #166 from Pen-y-Fan/php72 
Php72
 2020-07-27 10:29:35 +02:00
Emily Bache
ce38179dbd
Merge pull request #165 from rrokkam/rust-update 
Update Rust to 2018 edition
 2020-07-27 10:26:09 +02:00
Emily Bache
185fa40b80
Merge pull request #164 from emilybache/dependabot/npm_and_yarn/js-jest/lodash-4.17.19 
Bump lodash from 4.17.15 to 4.17.19 in /js-jest
 2020-07-27 10:24:38 +02:00
osh
64d521d9a3 Create texttest settings for TypeScript version 2020-07-24 21:45:33 +01:00
Pen-y-Fan
b4a02d3f5e Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:49:59 +01:00
Pen-y-Fan
ed7a787e4f Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:47:36 +01:00
rrokkam
45e53e823b Bump to 2018 edition 2020-07-19 13:51:32 -07:00
rrokkam
d897d295b7 Update Cargo.toml; bump version number 2020-07-19 13:51:27 -07:00
rrokkam
2ebbc987fb Make Item::new take Into<String> as a name 
This clears a lot of Rust-specific String boilerplate, so it's not
necessary to type String::from("foo") every time we want an item
with name "foo". It also makes the code look more similar to the C#
version of the code.

I am leaving the public struct members in because those are more
similar to the matching code in the other languages' implementations.
 2020-07-19 13:51:27 -07:00
rrokkam
c88bdfd53e Implement Display for Item 
This is a more idiomatic way of printing the contents of an object
than reaching into its innards. It is also more 1-1 with the original
C# code, which overrides toString for Item.
 2020-07-19 13:51:27 -07:00
rrokkam
f21ed2ae13 Make main.rs clippy-clean 2020-07-19 13:51:23 -07:00
rrokkam
b9372efe6f Use 2018-edition field init shorthand 2020-07-19 13:50:50 -07:00