OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2025-12-12 12:22:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
969 Commits 1 Branch 0 Tags 36 MiB
eb8c92055f
Commit Graph

969 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Emily Bache
33373d6fd5
Merge pull request #206 from Neppord/fix-typescript 
Update typescript dependencies and the mocharc file
 2021-01-28 12:27:39 +01:00
Samuel Ytterbrink
70a9e74f68 Update typescript dependencies and the mocharc file 2021-01-28 12:21:03 +01:00
Emily Bache
de2d37904a
Merge pull request #203 from rubberduck203/master 
Make rust text based approval tests pass
 2020-12-21 08:52:57 +01:00
Christopher J. McClellan
75c6303cee Make rust text based approval tests pass 
The main method for approval tests are supposed to run 30 days.
Previous impl was using an exclusive range.
Use an inclusive range instead.
 2020-12-20 14:06:26 -05:00
Emily Bache
1d71dbc460
Merge pull request #199 from JeffHoover/patch-1 
Remove broken links to cyber-dojo from README.md
 2020-12-11 07:53:56 +01:00
Jeff Hoover
afe5350167
Remove broken links to cyber-dojo from README.md 
Like the the README.md files for Racing-Car-Katas and the Tennis-Refactoring-Kata did, this README.md for GildedRose-Refactoring-Kata has. 
(This is my last PR about cyber-dojo.)
 2020-12-10 14:15:07 -05:00
Kieran
0c61f88ffc
Used consistant calling syntax in tests 2020-10-16 19:12:05 +08:00
Kieran
908055ba3e
Gilded rose in Nim 
- I've started with a small refactor, Command to function. This was done as
   the most obvious way to do it (to me) as in the original, would not compile
   in Nim due to violating memory lifetimes. I could have made it take a
   ref seq[Item], but then I would need to instatiate a ref seq and I didn't
   want to make a change that drastic. Also due to Nim's UFCS, the ultimate
   implementation would be basically the same anyway.
 2020-10-16 18:59:43 +08:00
Emily Bache
e2c5826e71
Merge pull request #184 from ag4ta/change-line-separator 
Unify line separator in ruby example
 2020-09-27 08:50:29 +02:00
Agata Werszler
50daf3f025 Change line separator from CRLF to LF 2020-09-25 16:45:40 +02:00
Emily Bache
5ed37f4be5
Merge pull request #182 from mebusw/patch-2 
Update some words with explanation for paronomasia
 2020-09-25 08:33:11 +02:00
Jacky Shen
b713f7370d
Update GildedRoseRequirements_zh.txt 2020-09-25 13:05:39 +08:00
Emily Bache
a8dd468300
Merge pull request #179 from emilybache/dependabot/composer/php/symfony/http-kernel-5.1.5 
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php
 2020-09-08 14:51:16 +00:00
Emily Bache
b4a6bc2445
Merge pull request #178 from emilybache/dependabot/npm_and_yarn/js-jest/yargs-parser-13.1.2 
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest
 2020-09-08 14:47:05 +00:00
dependabot[bot]
9c42d32cf4
Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php 
Bumps [symfony/http-kernel](https://github.com/symfony/http-kernel) from 5.0.8 to 5.1.5.
- [Release notes](https://github.com/symfony/http-kernel/releases)
- [Changelog](https://github.com/symfony/http-kernel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/symfony/http-kernel/compare/v5.0.8...v5.1.5)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:27:13 +00:00
dependabot[bot]
e5d807ebeb
Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest 
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-08 13:26:39 +00:00
Emily Bache
99703481d7
Merge pull request #177 from emilybache/dependabot/npm_and_yarn/js-jest/handlebars-4.7.6 
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest
 2020-09-08 11:34:41 +00:00
dependabot[bot]
8140c13575
Bump handlebars from 4.4.3 to 4.7.6 in /js-jest 
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.4.3 to 4.7.6.
- [Release notes](https://github.com/wycats/handlebars.js/releases)
- [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md)
- [Commits](https://github.com/wycats/handlebars.js/compare/v4.4.3...v4.7.6)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-09-07 14:24:39 +00:00
Emily Bache
1c94a43a2d
Merge pull request #176 from olivierperez/fix/adjust-fr-requirements 
Adjust a bit French requirements
 2020-09-07 13:46:10 +00:00
Olivier PEREZ
e5c0d2653c Adjust a bit French description 2020-09-06 16:00:37 +02:00
Emily Bache
94b6e7a1e8
Merge pull request #174 from wpanas/upgrade_kotlin 
Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6
 2020-08-21 11:12:02 +00:00
wpanas
cce7b6381f Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6 2020-08-20 14:44:45 +02:00
Emily Bache
cd4e977616
Merge pull request #171 from nihonbuson/master 
Create GildedRoseRequirements_jp.md
 2020-08-17 05:50:10 +00:00
nihonbuson
30d1966bbe
Update GildedRoseRequirements_jp.md 
改行を変更した。
 2020-08-17 10:47:34 +09:00
nihonbuson
936c96524b
Create GildedRoseRequirements_jp.md 
日本語訳を作成
 2020-08-17 10:46:24 +09:00
Emily Bache
28443f97b2
Merge pull request #167 from mergermarket/ts-texttest 
Create texttest settings for TypeScript version
 2020-07-27 10:32:26 +02:00
Emily Bache
ef5d1ffb9f
Merge pull request #166 from Pen-y-Fan/php72 
Php72
 2020-07-27 10:29:35 +02:00
Emily Bache
ce38179dbd
Merge pull request #165 from rrokkam/rust-update 
Update Rust to 2018 edition
 2020-07-27 10:26:09 +02:00
Emily Bache
185fa40b80
Merge pull request #164 from emilybache/dependabot/npm_and_yarn/js-jest/lodash-4.17.19 
Bump lodash from 4.17.15 to 4.17.19 in /js-jest
 2020-07-27 10:24:38 +02:00
osh
64d521d9a3 Create texttest settings for TypeScript version 2020-07-24 21:45:33 +01:00
Pen-y-Fan
b4a02d3f5e Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:49:59 +01:00
Pen-y-Fan
ed7a787e4f Updated PHP version for PHP7.2+ 
Removed PHP5 (no longer supported)
Renamed PHP7 to PHP - consistent with other kata
Added the same helpers as other PHP Kata
Updated the code to PHP7.2+ standard
Didn't change GildedRose updateQuality method
Updated GildedRoseTest (still failing)
Added ApprovalTest (passing)
- same text file as texttests / ThirtyDays / stdout.gr (only renamed).
 2020-07-23 22:47:36 +01:00
rrokkam
45e53e823b Bump to 2018 edition 2020-07-19 13:51:32 -07:00
rrokkam
d897d295b7 Update Cargo.toml; bump version number 2020-07-19 13:51:27 -07:00
rrokkam
2ebbc987fb Make Item::new take Into<String> as a name 
This clears a lot of Rust-specific String boilerplate, so it's not
necessary to type String::from("foo") every time we want an item
with name "foo". It also makes the code look more similar to the C#
version of the code.

I am leaving the public struct members in because those are more
similar to the matching code in the other languages' implementations.
 2020-07-19 13:51:27 -07:00
rrokkam
c88bdfd53e Implement Display for Item 
This is a more idiomatic way of printing the contents of an object
than reaching into its innards. It is also more 1-1 with the original
C# code, which overrides toString for Item.
 2020-07-19 13:51:27 -07:00
rrokkam
f21ed2ae13 Make main.rs clippy-clean 2020-07-19 13:51:23 -07:00
rrokkam
b9372efe6f Use 2018-edition field init shorthand 2020-07-19 13:50:50 -07:00
rrokkam
972e00541a Move gildedrose/mod.rs -> gildedrose.rs 
Avoiding putting simple one-file modules in their own folder.
 2020-07-19 13:49:13 -07:00
rrokkam
87f3e536a4 Risky: Move tests into mod.rs 
Usual Rust practice is to put tests in the same file they are testing.
I don't see any magic in the texttests that would require tests and code
to be in separate files, but I am not entirely sure, so I added the
risky tag.
 2020-07-19 13:47:02 -07:00
rrokkam
2a53bf5db5 Delete imports that are already in the prelude 
`Vec` and `String` are in the prelude, so qualifying them with
`vec::Vec` and `string::String` is unnecessary.
 2020-07-19 13:45:35 -07:00
rrokkam
a699803ce7 cargo fmt 
Standard Rust formatting practice
 2020-07-19 13:45:01 -07:00
dependabot[bot]
c5543783cb
Bump lodash from 4.17.15 to 4.17.19 in /js-jest 
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-07-18 13:03:07 +00:00
emily
fbe24e35b5 starting test should fail at the start 2020-06-08 13:58:55 +02:00
emily
e1fdd00962 starting position should include item printer 2020-06-05 15:36:03 +02:00
emily
3ee479a731 new cpp version with just catch2 and approvals. Builds faster than the version in the cpp folder 2020-06-05 15:24:28 +02:00
Emily Bache
59fa896633
Merge pull request #157 from LarsEckart/master 
update gradle wrapper & junit5 dependency
 2020-06-04 09:52:49 +02:00
Lars Eckart
0f729f3192 update gradle wrapper & junit5 dependency 2020-06-04 10:22:28 +03:00
Emily Bache
82a0083ead
Merge pull request #143 from fpellet/plpgsql_pgtap 
[plpgsql] Merge pgunit and pgtap
 2020-06-04 08:00:21 +02:00
emily
35d2cef888 use TEXTTEST_HOME instead of TEXTTEST_CHECKOUT since it is now set to current working directory in latest texttest version 2020-05-07 15:33:04 +02:00