OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 17:21:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
970 Commits 1 Branch 0 Tags 39 MiB
ef9c478e7c
Commit Graph

970 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Arno Chauveau
ef9c478e7c Move backstage pass logic to backstage-pass-behavior 2025-07-24 15:08:07 +02:00
Arno Chauveau
cc8a2b35b0 Refactor tests 
- moved snapshot tests to better named folder
- refactored gilded-rose tests to unit tests in their right location.
- mock implementation details in gilded rose test
- wrote unit tests for behavior resolver
- fix testing config to account for the changes
 2025-07-24 12:56:19 +02:00
Arno Chauveau
372111147f Moved Aged Brie logic to AgedBrieBehavior 2025-07-24 11:50:17 +02:00
Arno Chauveau
1563d86e90 Move logic that maps item names to Update behavior to a new resolver file 2025-07-24 11:49:33 +02:00
Arno Chauveau
f35d2e9c84 Introduce improved file structure, move update logic to legacyBehavior class 
- move item to it’s own file.
- Change tsconfig to use ‘@app’ prefix for imports
- move the logic to the legacy-behavior file, allowing to refactor out 
item type by item type
 2025-07-24 11:49:26 +02:00
Arno Chauveau
737704e19e Use Array.prototype.map over a for loop 
Use Array.prototype.map over a for loop so that we don’t have to use 
array indexing all the time.
 2025-07-24 10:17:36 +02:00
Arno Chauveau
6445f7f797 Use strict equality operator over loose equality operator 
Use strict equality operator over loose equality operator because it 
is seen as a best practice in the js/ts community.
 2025-07-24 10:17:36 +02:00
Arno Chauveau
ba40febb07 Add some comments to code that can't be changed because of requirements 2025-07-24 10:17:36 +02:00
Arno Chauveau
3872d78106 Add Todo for new functionality 2025-07-24 10:17:36 +02:00
Arno Chauveau
dcbf92c3aa Use a modern EcmaScript version 2025-07-24 10:17:36 +02:00
Arno Chauveau
b769e4539e write unit tests for currently implemented code 2025-07-24 09:49:27 +02:00
Arno Chauveau
40c997220d refactor snapshot tests 
- refactor snapshot tests to not use the console output and text test. 
- Remove texttest rig python script
- generate snapshot file
 2025-07-23 15:15:32 +02:00
Arno Chauveau
843a2c639b cleanup unused test frameworks 2025-07-23 14:51:12 +02:00
Arno Chauveau
0dd072b9ac fix failing unit test 
fix the failing unit test for gilded-rose.spec.ts
 2025-07-23 14:49:49 +02:00
Emily Bache
469544bd82
Update README.md with -m unittest 2025-07-17 15:44:35 +02:00
emily
58a991fe27 Added approvals version of python test 2025-06-22 17:30:00 +02:00
Andy Waite
69245fd714 Fix invalid Ruby syntax 2025-06-04 18:42:28 +02:00
Emily Bache
d3057d9fb1
Merge pull request #624 from dmcg/master 
Simplify Item and make items property in GildedRose immutable because it was in Java
 2025-05-12 08:47:36 +00:00
Duncan McGregor
048d719f75
Merge branch 'emilybache:main' into master 2025-05-12 09:40:35 +01:00
Duncan McGregor
5358002d45 Reformat Item ctor and simplify toString 2025-05-12 09:39:48 +01:00
Duncan McGregor
eded7b38b5 Refactor GildedRose to use val instead of var for items, to better reflect the Java version. 2025-05-12 09:38:18 +01:00
Emily Bache
ab8c05935b
Merge pull request #620 from RorySan/fsharp-update 
Fsharp updated to .NET 9
 2025-05-09 12:28:36 +00:00
Rory
56bc90d53d Fsharp updated to .NET 9 2025-05-09 11:44:12 +02:00
Sasha Schwartz
d73f961089 separate files based on feedback 2025-05-04 13:29:08 +02:00
Sasha Schwartz
eb9b46e34d add Odin lang 2025-05-04 13:29:08 +02:00
Emily Bache
af3e2244b3
Merge pull request #616 from Younes-Charfaoui/arabic-translation 
🐪 Adding Arabic translation for the requirements
 2025-04-29 06:04:29 +00:00
Younes Charfaoui
97d98be1f4
Update GildedRoseRequirements_ar.md 2025-04-28 16:31:46 +01:00
Younes Charfaoui
b27409e72e Adding arabic translation for the requirments 2025-04-28 16:24:22 +01:00
Emily Bache
4b04f58363
Merge pull request #615 from dmcg/master 
Upgrading versions for the Kotlin project
 2025-04-15 06:12:34 +00:00
Duncan McGregor
1b01ed06cd Upgradle to 8.13 for Kotlin 2025-04-14 12:55:32 +01:00
Duncan McGregor
1dcc7ef316 Upgrade Kotlin 2025-04-14 12:53:23 +01:00
Duncan McGregor
8e26832f59 Upgrade JUnit for Kotlin, add kotlinx.test 2025-04-14 12:53:22 +01:00
Emily Bache
fcd540f80d
Merge pull request #613 from olliekennedy/fix-kotlin-texttest 
Enable texttest to run in the Kotlin project
 2025-04-04 11:48:22 +00:00
Ollie Kennedy
d87d813367
add kotlin gradle task to run texttest 
`./gradlew -q text` now works

Co-authored-by: Marco Garofalo <marcogarofalo.personal@gmail.com>
 2025-04-04 12:35:29 +01:00
Emily Bache
b3a0463bba
Merge pull request #601 from adampridmore/Adam2 
Update scala project from scala 2 to scala 3
 2025-03-17 09:59:21 +00:00
Emily Bache
fd1e798baf
Merge pull request #600 from Margarita23/improve-the-translation-ua 
Improve the translation of the specification in Ukrainian
 2025-03-17 09:53:27 +00:00
adampridmore
4af5375695
Updae to scala 3 2025-03-15 21:36:24 +00:00
Adam Pridmore
dd26a2d3b6
Merge pull request #1 from emilybache/main 
Pull latest
 2025-03-15 20:37:46 +00:00
Marharyta Andriukhina
4e77e34f22 Improve the translation of the specification in Ukrainian 2025-03-15 15:40:23 +02:00
Emily Bache
71261052fa
Merge pull request #596 from tbeu/update-cpp-cmake 
Add test specific CMake options to C++ configuration
 2025-02-16 05:57:30 +00:00
tbeu
85cc3d0171 Remove cpp-catch2 in favor of cpp. 2025-02-15 09:38:46 +01:00
tbeu
784920714a Introduce four CMake options to enable/disabled test variants or test frameworks 
By default all four test variants (Catch2 vs. GTest and Approval vs. Unit) are enabled.
 2025-02-15 09:38:07 +01:00
Emily Bache
afd4627ee1
Merge pull request #591 from tbeu/fix-cpp-code-smells 
Fix C++ code smells
 2025-02-13 05:42:25 +00:00
tbeu
73a51ef14f Fix C++ code smells 
* Move "using namespace std;" from header to module file (to no longer pollute the global namespace).
* Fix inconsistency of having namespace prefix in test code.
* Add include guard to GildedRose.h.
* Avoid std::endl.
* Have consistent white-space.
 2025-02-12 20:56:22 +01:00
Emily Bache
6c59257f27
Merge pull request #590 from tbeu/restructure-cpp-build-targets 
Restructure C++ CMake build targets
 2025-02-12 05:43:26 +00:00
tbeu
3bf108ef0e Restructure build targets of CMake configuration 
* Rename the library under test from src to GildedRoseLib.
* Move the lib folder to test/third_party and handle ApprovalTests.hpp as header-only dependency.
* Remove the superfluous googletest_approval_main.cpp (in the same sense as there is only one GildedRoseCatch2ApprovalTests.cc)
* Set USE_FOLDERS property such that target ALL_BUILD, RUN_TESTS and ZERO_CHECK are grouped for Visual Studio.
* Set WORKING_DIRECTORY such that the RUN_TESTS target works successfully.
* Fix C++ language standard for Catch2 v3 to C++14.
* Bump third-party dependencies
  * Update ApprovalTests.hpp to v10.13.0
  * Update Catch2 to v3.8.0
  * Update GTest to v1.16.0
 2025-02-11 23:04:23 +01:00
emily
a9fe49d2b6 fix layout 2025-02-03 11:52:22 +01:00
emily
b75802f675 newer version of junit and approvals 2025-02-03 11:51:43 +01:00
Birame Sene
4a7c2643c0 fix: typo 2025-01-22 18:36:51 +01:00
Birame Sene
288fa66728 chore: get rid of unneccessary configuration 2025-01-22 18:36:51 +01:00