GildedRose-Refactoring-Kata

OpenSource/GildedRose-Refactoring-Kata

Fork 0

mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 14:31:28 +00:00

Commit Graph

Select branches

Hide Pull Requests

main

#1

#100

#101

#102

#103

#104

#105

#106

#107

#109

#11

#110

#111

#112

#113

#114

#115

#117

#118

#12

#120

#121

#122

#123

#124

#126

#127

#128

#129

#13

#130

#131

#132

#133

#134

#135

#136

#137

#138

#139

#14

#140

#141

#142

#143

#144

#145

#146

#147

#148

#149

#15

#150

#151

#152

#153

#154

#155

#156

#157

#159

#16

#160

#161

#162

#163

#164

#165

#166

#167

#168

#169

#17

#170

#171

#172

#173

#174

#176

#177

#178

#179

#18

#180

#181

#182

#183

#184

#185

#186

#187

#188

#189

#19

#190

#191

#192

#193

#194

#196

#197

#198

#199

#2

#20

#200

#201

#202

#203

#204

#205

#206

#207

#208

#209

#21

#210

#211

#212

#214

#215

#216

#217

#218

#219

#22

#22

#220

#221

#222

#223

#224

#225

#226

#227

#228

#229

#23

#230

#231

#232

#233

#234

#235

#236

#237

#238

#239

#24

#24

#240

#241

#242

#243

#244

#245

#246

#247

#248

#249

#25

#25

#250

#251

#252

#253

#254

#255

#256

#257

#258

#259

#26

#260

#261

#262

#264

#265

#266

#267

#268

#27

#270

#271

#272

#273

#274

#275

#276

#277

#278

#279

#28

#280

#281

#282

#283

#284

#285

#286

#287

#288

#289

#29

#290

#291

#292

#293

#294

#295

#296

#297

#298

#299

#3

#30

#30

#300

#301

#302

#303

#304

#305

#306

#307

#308

#309

#31

#310

#311

#313

#314

#315

#316

#317

#318

#319

#320

#321

#322

#323

#324

#325

#326

#327

#328

#329

#33

#330

#331

#332

#333

#334

#335

#336

#337

#338

#339

#340

#341

#342

#343

#344

#345

#346

#347

#348

#349

#35

#350

#351

#352

#353

#354

#355

#356

#357

#358

#36

#361

#362

#363

#364

#365

#366

#367

#368

#369

#37

#370

#371

#372

#373

#374

#375

#376

#377

#378

#379

#38

#38

#380

#381

#382

#383

#384

#385

#386

#387

#388

#389

#39

#39

#390

#391

#392

#393

#394

#395

#396

#397

#399

#4

#40

#400

#401

#402

#403

#404

#405

#406

#407

#409

#41

#410

#411

#412

#413

#414

#415

#416

#417

#418

#419

#42

#420

#421

#422

#423

#424

#425

#426

#427

#428

#429

#430

#431

#432

#433

#434

#435

#436

#437

#438

#439

#44

#440

#441

#442

#443

#445

#446

#447

#448

#449

#450

#451

#451

#452

#453

#454

#455

#456

#457

#458

#459

#46

#460

#461

#462

#463

#464

#466

#467

#468

#469

#47

#470

#471

#473

#474

#475

#476

#477

#478

#479

#48

#480

#481

#482

#483

#484

#485

#486

#487

#488

#489

#49

#490

#491

#492

#493

#495

#496

#497

#498

#499

#5

#50

#500

#501

#502

#503

#504

#505

#506

#508

#509

#51

#510

#511

#512

#513

#514

#515

#516

#517

#518

#519

#52

#520

#521

#522

#523

#524

#525

#527

#528

#529

#53

#53

#530

#531

#532

#533

#534

#535

#536

#537

#538

#539

#54

#540

#542

#543

#544

#545

#546

#547

#548

#549

#55

#550

#551

#552

#553

#554

#555

#556

#557

#558

#559

#56

#560

#562

#563

#564

#565

#566

#567

#568

#569

#57

#57

#570

#571

#572

#573

#574

#575

#576

#577

#578

#58

#580

#581

#582

#583

#584

#585

#586

#587

#588

#589

#59

#590

#591

#594

#595

#596

#597

#598

#599

#6

#60

#600

#601

#602

#603

#604

#605

#606

#607

#608

#608

#609

#609

#61

#610

#611

#612

#613

#614

#615

#616

#617

#618

#619

#62

#620

#621

#622

#623

#624

#625

#626

#627

#628

#629

#63

#630

#631

#632

#633

#634

#635

#636

#637

#638

#639

#64

#640

#641

#642

#643

#643

#645

#646

#647

#648

#649

#65

#65

#650

#651

#652

#653

#654

#655

#656

#657

#658

#659

#66

#66

#660

#661

#662

#663

#664

#665

#666

#667

#668

#669

#67

#67

#670

#671

#672

#673

#674

#675

#676

#677

#677

#678

#679

#68

#680

#681

#682

#683

#684

#685

#686

#687

#688

#689

#69

#690

#691

#692

#693

#694

#695

#696

#7

#7

#70

#71

#71

#72

#72

#73

#73

#74

#74

#75

#76

#77

#77

#78

#78

#79

#79

#8

#80

#81

#82

#82

#83

#84

#85

#85

#86

#87

#88

#88

#89

#9

#90

#91

#92

#92

#93

#94

#95

#95

#96

#97

#98

#99

317d04c61d

Merge branch 'emilybache:main' into main uivraeus 2023-02-20 12:45:26 +0100
952bbc5274 chore: updating readme on java folder with the correct testing coverage pierre 2023-02-19 16:52:21 +0100
e94ee451b3 test: adding toString unit test pierre 2023-02-19 16:49:17 +0100
93373b6a13

Merge pull request #7 from pcroch/feat-adding_jacoco_plugin Pierre 2023-02-19 16:43:40 +0100
ca6cf0f665 chore: adding jacoco reports pierre 2023-02-19 16:43:12 +0100
2be976bde8 chore: adding comments for archlinux graddle user pierre 2023-02-19 16:36:53 +0100
e712c300f7 chore: adding description for README.md in JAVA folder pierre 2023-02-19 16:34:05 +0100
147762dd67 feat: adding jacoco plugin in the POM pierre 2023-02-19 16:33:37 +0100
bc25fddb88

Merge pull request #6 from pcroch/feat/implementing_java_bean_convention_on_Item_class Pierre 2023-02-19 16:20:39 +0100
8a2e2e7876 test: adding some others units tests for object Item pierre 2023-02-19 16:16:51 +0100
ce18e35be7 chore: change in the argument name for setters pierre 2023-02-19 16:16:26 +0100
f0fe95be85 feat: making the Item class respecting the Encapsulation Principle pierre 2023-02-19 16:04:40 +0100
3c51e0ad35

Merge pull request #5 from pcroch/refactor/trying_to_simply_the_code Pierre 2023-02-19 15:46:30 +0100
1f1275f4db refactor: improving the placement of the SellIn Counter to make the placement more intuitive pierre 2023-02-19 15:45:20 +0100
2935556281 test: adding some more test case to increase coverage pierre 2023-02-19 15:44:18 +0100
557ba0eb73 chore: cleaning the class GildedRose.java pierre 2023-02-19 15:30:17 +0100
f6f99c1cef test; adding a new test cases pierre 2023-02-19 15:29:26 +0100
c68e0b3dcd chore: improving comments for better clarity pierre 2023-02-19 15:13:36 +0100
e326caf567 refactor: adding a guard clause for Sulfuras item to avoid to check later on pierre 2023-02-19 15:12:49 +0100
6154339c39 refactor: simplifying the condition when the SellIn value is negative pierre 2023-02-19 15:04:49 +0100
7473f39aec refactor: improving the if/else decision to avoid Logical NOT operator and ease the code comprehension pierre 2023-02-19 14:46:19 +0100
15f4d079a6 refactor: adding a guard clause in the updateItem method pierre 2023-02-19 14:07:23 +0100
0514a8ea67 test: changing the assert value pierre 2023-02-19 13:53:35 +0100
a6e85220e8 test: fine tunings the test cases to improve clarity pierre 2023-02-19 13:48:51 +0100
379648a572 feat: adding a updateItem method to keep the code dry pierre 2023-02-19 13:29:50 +0100
035e646326 refactor: moving up the gaurd clause for quality < 50 pierre 2023-02-19 13:16:32 +0100
0906d3c42b

Merge pull request #4 from pcroch/fix/completing_refactoring Pierre 2023-02-19 13:12:17 +0100
095d5edc82 refactor: change the test cases name to improve clarity pierre 2023-02-19 12:57:57 +0100
102adc0792 fix: updating the tesText file for the product decreasing quality pierre 2023-02-19 12:39:21 +0100
6c46c2d182 fix: updating a test case pierre 2023-02-19 12:37:01 +0100
a19592a19f feat: adding new products pierre 2023-02-19 12:36:49 +0100
85cafea70a feat: adding a test cases pierre 2023-02-19 11:54:38 +0100
327d26c7dd

Merge pull request #3 from pcroch/refactor/refactoring_the_updateQuality_Class Pierre 2023-02-19 10:36:30 +0100
33f38a7ec9 refactor: making the UpdateQuality method more readable by removing the tree of if/else statements while adding more specific tests cases to avoid regression pierre 2023-02-19 10:33:27 +0100
ef58e2bf7a fix: fixing the itemSulfurasNotChangeQuality test case pierre 2023-02-18 18:38:02 +0100
f691744b2b refactor: adding more test cases to increase testing coverage pierre 2023-02-18 18:12:01 +0100
a81faa5f29 refactor: moving up guard clause for TAFKAL80ETC Concert if quality is inferior to 50 pierre 2023-02-18 17:34:19 +0100
f2b170a736

Merge pull request #2 from pcroch/feat/adding_test_cases_for_improve_coverage Pierre 2023-02-18 17:13:04 +0100
34f7bb83b1 refactor: moving COnjured test cases into the UpdateQualityTest class pierre 2023-02-18 17:11:42 +0100
01718e904e feat: adding testing for incoming features pierre 2023-02-18 17:00:51 +0100
4bf6facef3 feat: adding basic unit tests for the GildedRose.java class pierre 2023-02-18 16:35:16 +0100
6bcf21d33b

Merge pull request #1 from pcroch/init/initial_setup_of_repo Pierre 2023-02-18 15:06:00 +0100
70ad8fa790 fix: changing config file to run the app locally pierre 2023-02-18 15:00:37 +0100
0a49bf842f test: saving the initial test snapshot for later testing pierre 2023-02-18 14:52:37 +0100
8249460e7e Remove unneded dirs, updated README Elliott Allmann 2023-02-16 20:41:19 -0800
53b29ef6e4

Update README.md Facundosalvarez 2023-02-14 11:42:56 +0100
ef262b72e8 Update: Refactored the codebase by adding more tests and implementing conjured items. Facundo Alvarez 2023-02-14 11:37:05 +0100
b11b0ff8e1 Update: Refactored the codebase by adding more tests and implementing conjured items. Facundo Alvarez 2023-02-14 11:17:32 +0100
8f2fec5cd8 Added tests Murat Bataray 2023-02-10 00:26:33 +0100
7a7102c9cb extracted bulk of if checks and cleaned up method Murat Bataray 2023-02-10 00:22:43 +0100
2d5d980dd2 extracted conjured variable Murat Bataray 2023-02-09 23:50:27 +0100
d0cb683b03 Extracted range checks and added helper methods + constants Murat Bataray 2023-02-09 23:42:39 +0100
584d658dd6 Added tests to project Murat Bataray 2023-02-09 23:02:50 +0100
1a7b487325 fixed failing test Murat Bataray 2023-02-09 21:52:49 +0100
820e796fd8

Merge pull request #405 from nitsanavni/add-ci Emily Bache 2023-02-08 08:30:44 +0100
59becfb7f6 update quality code Sai Sharan Kumar Vuppala 2023-02-07 18:13:35 -0600
8ee93709a5 jq ci: compare to 30 days texttest stdout Nitsan Avni 2023-02-07 17:06:14 +0000
e7545c322e back to green, rename job Nitsan Avni 2023-02-07 14:27:11 +0000
6f17a85b91 intentionally fail the ci Nitsan Avni 2023-02-07 14:21:33 +0000
714d60b092 ci: test texttest result Nitsan Avni 2023-02-07 14:14:13 +0000
f982992850 diff action Nitsan Avni 2023-02-07 12:39:03 +0000
6527ea8bc3 add jq.yml workflow Nitsan Avni 2023-02-07 12:31:13 +0000
0fa2c2e623

Merge pull request #404 from nitsanavni/jq Emily Bache 2023-02-07 16:10:27 +0100
9a2736d267 use foreach for extra indentation Nitsan Avni 2023-02-07 08:35:39 +0000
9abe955027 add jq translation Nitsan Avni 2023-02-06 22:38:45 +0000
e72499d0ee add few more tests for legendary item Kirti Deshmukh 2023-02-03 08:22:30 +0530
4483927360 add some more tests for items with upgrading quality on or after sellIn is zero Kirti Deshmukh 2023-02-03 08:19:37 +0530
a44dac3f17 add some more tests for items with upgrading quality on or after sellIn is zero Kirti Deshmukh 2023-02-03 08:17:38 +0530
3e58c3d0d5 general refactoring | introduce upgradeBy Kirti Deshmukh 2023-02-03 08:12:10 +0530
4b3e84facb general refactoring Kirti Deshmukh 2023-02-03 08:07:03 +0530
172bb39d30 add tests for conjured on and after sellIn date is zero Kirti Deshmukh 2023-02-03 08:05:11 +0530
eb48f26dc3 add tests for conjured before sellIn date is non zero Kirti Deshmukh 2023-02-03 08:02:20 +0530
5ed7391ddb add some more tests for items whose quality increases as sellIn passes Kirti Deshmukh 2023-02-03 07:27:13 +0530
8f0fd65af8 add tests for various types of items Kirti Deshmukh 2023-02-03 07:13:36 +0530
2baced7d94 add parameterized test Kirti Deshmukh 2023-02-03 06:59:59 +0530
8ab2ff61df rename test Kirti Deshmukh 2023-02-03 06:53:11 +0530
4bc71d19b7 asset other attributes for item Kirti Deshmukh 2023-02-03 06:51:00 +0530
db523fd0aa apply IDE suggested simplification for expression Kirti Deshmukh 2023-02-03 06:49:59 +0530
fbb5874cd2 use enhanced for loop Kirti Deshmukh 2023-02-03 06:49:03 +0530
f3e4379543 fix failing test Kirti Deshmukh 2023-02-03 06:48:06 +0530
fe3cc75ca4 Change from text file to markdown file Clare Sudbery 2023-02-01 17:11:47 +0000
f097af285a Better punctuation and clearer wording. Clare Sudbery 2023-02-01 17:11:08 +0000
79d93906da Fix bullet lists Clare Sudbery 2023-02-01 17:10:16 +0000
c0c0c52985 Fix formatting Clare Sudbery 2023-02-01 17:07:27 +0000
bacb1d9394 Add initial source of truth for C# approvals Clare Sudbery 2023-02-01 16:05:11 +0000
7700d349c3 Comment out C# texttest config by default Clare Sudbery 2023-02-01 16:03:04 +0000
f8a87ce507 Fix texttest config to work for csharp Clare Sudbery 2023-02-01 16:01:52 +0000
608f8ddb58 Refactroring completed: 4 methods extracted to update each item indivdaully. Additionally, unit test added to handle most and edge cases efeleke 2023-01-19 10:29:11 -0600
baaada9449 Refactroring completed: 4 methods extracted to update each item indivdaully. Additionally, unit test added to handle most and edge cases efeleke 2023-01-19 10:29:04 -0600
aceaf4ac44 fix: added some test cases Mohit 2023-01-16 21:08:38 -0800
cb735ed585 fix: code Mohit 2023-01-16 20:59:39 -0800
c67a0393e4 refactor: refactor the existing function and added test cases Sneha Patil 2023-01-17 00:03:33 -0500
100fb3620a remove dead better code hub emily 2023-01-16 08:19:13 +0100
d7b0cefc1a remove BetterCode Hub, since it's no longer working. Improve info on TextTest. emily 2023-01-16 08:17:49 +0100
d69dbd2b17 first commit kennethongcs 2023-01-14 16:45:48 +0800
54cf2e5da8

Merge pull request #396 from JasonMoon95/patch-1 Emily Bache 2023-01-13 14:44:04 +0100
58ec0e4bee

Update GildedRoseRequirements_kr.md Seungje Mun 2023-01-12 14:08:50 +0900
8d081db79b refactor and unit tests from pair-programming exercise Nick Orlando 2023-01-11 10:11:05 -0500
bfb5d5c93b Update to coumpound assignment expression Farid Zouheir 2023-01-09 19:51:23 +0000
c6040ed788

Merge pull request #393 from Pen-y-Fan/php8 Emily Bache 2023-01-09 08:41:09 +0100