GildedRose-Refactoring-Kata

OpenSource/GildedRose-Refactoring-Kata

Fork 0

mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-15 06:21:29 +00:00

Commit Graph

Select branches

Hide Pull Requests

main

#1

#100

#101

#102

#103

#104

#105

#106

#107

#109

#11

#110

#111

#112

#113

#114

#115

#117

#118

#12

#120

#121

#122

#123

#124

#126

#127

#128

#129

#13

#130

#131

#132

#133

#134

#135

#136

#137

#138

#139

#14

#140

#141

#142

#143

#144

#145

#146

#147

#148

#149

#15

#150

#151

#152

#153

#154

#155

#156

#157

#159

#16

#160

#161

#162

#163

#164

#165

#166

#167

#168

#169

#17

#170

#171

#172

#173

#174

#176

#177

#178

#179

#18

#180

#181

#182

#183

#184

#185

#186

#187

#188

#189

#19

#190

#191

#192

#193

#194

#196

#197

#198

#199

#2

#20

#200

#201

#202

#203

#204

#205

#206

#207

#208

#209

#21

#210

#211

#212

#214

#215

#216

#217

#218

#219

#22

#22

#220

#221

#222

#223

#224

#225

#226

#227

#228

#229

#23

#230

#231

#232

#233

#234

#235

#236

#237

#238

#239

#24

#24

#240

#241

#242

#243

#244

#245

#246

#247

#248

#249

#25

#25

#250

#251

#252

#253

#254

#255

#256

#257

#258

#259

#26

#260

#261

#262

#264

#265

#266

#267

#268

#27

#270

#271

#272

#273

#274

#275

#276

#277

#278

#279

#28

#280

#281

#282

#283

#284

#285

#286

#287

#288

#289

#29

#290

#291

#292

#293

#294

#295

#296

#297

#298

#299

#3

#30

#30

#300

#301

#302

#303

#304

#305

#306

#307

#308

#309

#31

#310

#311

#313

#314

#315

#316

#317

#318

#319

#320

#321

#322

#323

#324

#325

#326

#327

#328

#329

#33

#330

#331

#332

#333

#334

#335

#336

#337

#338

#339

#340

#341

#342

#343

#344

#345

#346

#347

#348

#349

#35

#350

#351

#352

#353

#354

#355

#356

#357

#358

#36

#361

#362

#363

#364

#365

#366

#367

#368

#369

#37

#370

#371

#372

#373

#374

#375

#376

#377

#378

#379

#38

#38

#380

#381

#382

#383

#384

#385

#386

#387

#388

#389

#39

#39

#390

#391

#392

#393

#394

#395

#396

#397

#399

#4

#40

#400

#401

#402

#403

#404

#405

#406

#407

#409

#41

#410

#411

#412

#413

#414

#415

#416

#417

#418

#419

#42

#420

#421

#422

#423

#424

#425

#426

#427

#428

#429

#430

#431

#432

#433

#434

#435

#436

#437

#438

#439

#44

#440

#441

#442

#443

#445

#446

#447

#448

#449

#450

#451

#451

#452

#453

#454

#455

#456

#457

#458

#459

#46

#460

#461

#462

#463

#464

#466

#467

#468

#469

#47

#470

#471

#473

#474

#475

#476

#477

#478

#479

#48

#480

#481

#482

#483

#484

#485

#486

#487

#488

#489

#49

#490

#491

#492

#493

#495

#496

#497

#498

#499

#5

#50

#500

#501

#502

#503

#504

#505

#506

#508

#509

#51

#510

#511

#512

#513

#514

#515

#516

#517

#518

#519

#52

#520

#521

#522

#523

#524

#525

#527

#528

#529

#53

#53

#530

#531

#532

#533

#534

#535

#536

#537

#538

#539

#54

#540

#542

#543

#544

#545

#546

#547

#548

#549

#55

#550

#551

#552

#553

#554

#555

#556

#557

#558

#559

#56

#560

#562

#563

#564

#565

#566

#567

#568

#569

#57

#57

#570

#571

#572

#573

#574

#575

#576

#577

#578

#58

#580

#581

#582

#583

#584

#585

#586

#587

#588

#589

#59

#590

#591

#594

#595

#596

#597

#598

#599

#6

#60

#600

#601

#602

#603

#604

#605

#606

#607

#608

#608

#609

#609

#61

#610

#611

#612

#613

#614

#615

#616

#617

#618

#619

#62

#620

#621

#622

#623

#624

#625

#626

#627

#628

#629

#63

#630

#631

#632

#633

#634

#635

#636

#637

#638

#639

#64

#640

#641

#642

#643

#643

#645

#646

#647

#648

#649

#65

#65

#650

#651

#652

#653

#654

#655

#656

#657

#658

#659

#66

#66

#660

#661

#662

#663

#664

#665

#666

#667

#668

#669

#67

#67

#670

#671

#672

#673

#674

#675

#676

#677

#677

#678

#679

#68

#680

#681

#682

#683

#684

#685

#686

#687

#688

#689

#69

#690

#691

#692

#693

#694

#695

#696

#7

#7

#70

#71

#71

#72

#72

#73

#73

#74

#74

#75

#76

#77

#77

#78

#78

#79

#79

#8

#80

#81

#82

#82

#83

#84

#85

#85

#86

#87

#88

#88

#89

#9

#90

#91

#92

#92

#93

#94

#95

#95

#96

#97

#98

#99

4562b6d688 To begin taking advantage of new domain, use wrt backstage passes, and fix business logics Sam Burns 2024-01-24 15:52:46 +0000
df7caf6747 To simplify code, remove old business logic Sam Burns 2024-01-24 15:47:22 +0000
f826225132 To begin taking advantage of new domain, use wrt Sulfuras Sam Burns 2024-01-24 15:46:03 +0000
c1b9f465d3 To allow new domain to replace god object antipattern, make business logic work in gilded rose item classes Sam Burns 2024-01-24 15:37:47 +0000
9fdc9ab29f To prepare to move business logic out of god object antipattern, provide domain objects and factory pattern Sam Burns 2024-01-24 15:14:06 +0000
46f45e2661 To provide a place for unit tests, move approval tests and change config Sam Burns 2024-01-24 14:44:10 +0000
bad5ca93fd To provide a better behavioural test harness, add Behat tests for all features Sam Burns 2024-01-24 14:35:56 +0000
1a572c1eb7 To provide behavioural test infrastructure, add install Behat and add first test Sam Burns 2024-01-24 13:01:43 +0000
fb7d21042e To provide a basic test harness using existing infrastructure, add approval test expectations Sam Burns 2024-01-24 13:00:14 +0000
b6518c84c8 To restore coding standards of project, run ecs Sam Burns 2024-01-24 12:34:54 +0000
c7d64d3330

refactor glided rose kata shivani-330 2024-01-19 19:32:27 +0530
f6454c0eb9

Update gilded_rose.rb AkashMw 2024-01-19 19:14:27 +0530
2e4c4a8b2e modify logic and added Conjured items logic Ravina 2024-01-19 18:14:37 +0530
7e8becaa68

Merge branch 'main' into refactor-ruby Peter Kofler 2024-01-17 20:15:40 +0100
e43a1a270f Replace complete tests with sample tests. Peter Kofler 2024-01-17 20:12:19 +0100
92a459442a Fixed and add rspec Cp shivhare 2023-12-22 20:36:03 +0530
24c9a7f603 Fixed and add minitest Cp shivhare 2023-12-22 20:35:44 +0530
70ca9b9569 Made runnable for ruby Cp shivhare 2023-12-22 20:35:18 +0530
d28c76856c

added updateConjuredItem method and kept room for implementing the relevant business logic Chamoda Ranasinghe 2024-01-16 03:57:03 +0700
6109899ada

added CONJURED_CAKE key to ItemNames constant Chamoda Ranasinghe 2024-01-16 03:53:34 +0700
dc0af40495

cleared updateNormalItem method and asserted Chamoda Ranasinghe 2024-01-16 03:52:03 +0700
ddae445fec

cleared the updateSulfurasItem without affecting the test results Chamoda Ranasinghe 2024-01-16 03:45:48 +0700
ccf3cc6166

cleaned up updateSulfurasItem asserted item name ItemNames.SULFURAS Chamoda Ranasinghe 2024-01-16 03:38:09 +0700
7577596171

cleaned up updateBackstagePassesItem method asserted ItemNames.BACKSTAGE_PASSES Chamoda Ranasinghe 2024-01-16 03:33:11 +0700
98b400604e

cleaned up updateAgedBrieItem method assert AGED_BREE key Chamoda Ranasinghe 2024-01-16 03:20:58 +0700
5c9f3822a2

added 4 individual private methods to update each item based on name replicated main business logic to all 4 functions (can individually clean each function afterwards) added a switch statement in the main loop to call private methods Chamoda Ranasinghe 2024-01-16 03:15:20 +0700
4dd7622f7a

Code fixes fixed else if refractor in 2 places fixed item.quality - item.quality to item.quality = 0 Chamoda Ranasinghe 2024-01-16 02:36:57 +0700
f6a3a6d718

added MAX_ITEM_QUALITY in constants file and referred it Chamoda Ranasinghe 2024-01-16 02:30:10 +0700
e44c0a1d18

created const file and added ItemNames constant obj to maintain a key against each item name Chamoda Ranasinghe 2024-01-16 02:25:45 +0700
aeae3bbdc3

replaced main for loop in updateQuality method with for.. of Chamoda Ranasinghe 2024-01-16 02:10:34 +0700
dc038c3f11

removed approval should foo 1 from jest snapshot Chamoda Ranasinghe 2024-01-16 02:08:28 +0700
5d3ffc9223

Prepare test files to make sure Approval testing before refactoring fixed failing unit test in jest/gilded-rose.spec.ts deleted "should foo" test case from approvals.spec.ts generated jest snapshot file (approvals.spec.ts.snap) Chamoda Ranasinghe 2024-01-16 02:04:18 +0700
4bfda69d39

Merge pull request #515 from bronsonmcn/ruby-fix Peter Kofler 2024-01-07 14:47:23 +0100
1bbc3b408a

doc - update command to run ruby tests Bronson McNaughton 2024-01-07 12:09:21 +1300
31bef1d837

Merge pull request #514 from nitsanavni/jq-simplify Peter Kofler 2024-01-06 22:38:30 +0100
39091d3b65

Merge pull request #513 from nitsanavni/bash Peter Kofler 2024-01-06 22:33:31 +0100
d5b430fde9 - r jq: jaq -> jq, rm foreach Nitsan Avni 2024-01-05 09:21:12 +0100
dc652d4d09 . t bash/texttest_fixture.sh temp file -> variable Nitsan Avni 2024-01-05 09:11:27 +0100
ba27c89b42 Create smaller submethods to update items fields Anna Klimova 2024-01-04 17:43:36 +0100
5a30f03ea4 Refactor update_quality() by splitting into meaningful branches Anna Klimova 2024-01-04 17:00:42 +0100
a759630e00 Add simple tests Anna Klimova 2024-01-04 16:40:43 +0100
2b01b0351e Added unit test for GildedRose class adityadev92 2024-01-03 16:26:45 +0530
c3d6116add Added spec for GildedRose class adityadev92 2024-01-03 16:07:20 +0530
90006cc3c1 Updated file to use 'require_relative' for internal file dependencies adityadev92 2024-01-03 15:52:43 +0530
55004bf856 Created separate file for 'Item' class adityadev92 2024-01-03 15:51:14 +0530
d04e29c319 Applied requested changes and eliminated the 'Item' class adityadev92 2024-01-03 15:50:25 +0530
52d5ffc8b4 Uncommented Ruby setting adityadev92 2024-01-03 13:45:06 +0530
a1e48be19f

Merge pull request #509 from nitsanavni/bash Emily Bache 2023-12-28 08:27:57 +0000
6223bf9919 - F more compact Nitsan Avni 2023-12-26 18:09:52 +0100
7658124173 gilded_rose.sh: closer to original Nitsan Avni 2023-12-26 12:27:11 +0100
887ad0b60d . d README: update field delimiter Nitsan Avni 2023-12-23 19:46:03 +0100
4490aaa5fd - t failing unit test Nitsan Avni 2023-12-23 18:18:38 +0100
56ca5bf411 - t verify results Nitsan Avni 2023-12-23 17:56:14 +0100
9039daa7be . d README.md notes Nitsan Avni 2023-12-23 17:29:46 +0100
bee8f54440 bash: initial impl Nitsan Avni 2023-12-23 17:26:19 +0100
87de8f8770 Fixed and add rspec Cp shivhare 2023-12-22 20:36:03 +0530
c1447ac41e Fixed and add minitest Cp shivhare 2023-12-22 20:35:44 +0530
b655f1842a Made runnable for ruby Cp shivhare 2023-12-22 20:35:18 +0530
f9926d9da7 Fix README.md for ruby Cp shivhare 2023-12-22 20:27:01 +0530
4c80a03125 refator code Naresh Singh 2023-12-22 17:27:53 +0530
fb9960b1f3

Merge pull request #506 from debashisbiswas/fix-requirements-link Emily Bache 2023-12-14 07:05:44 +0000
6ab4336a22

Fix link to requirements Debashis Biswas 2023-12-13 11:15:41 -0700
fa212ef9aa

Merge pull request #505 from VioletaCalvo/doc/markdown-for-ensglish-requirements Emily Bache 2023-12-11 07:00:28 +0000
4ef9d9b019 doc: use markdown for english requirements Violeta 2023-12-08 21:13:27 +0100
2f87ffd74e Updated inventory modification code pwnkmrshah 2023-12-08 14:26:21 +0530
318218e3bc Merge branch 'nim' Peter Kofler 2023-12-07 13:12:37 +0100
77a444b600 Standard ignores for Nim. Peter Kofler 2023-12-07 13:07:29 +0100
ab84d1696c Replace complete test with sample test. Peter Kofler 2023-12-07 13:07:18 +0100
59d0af0362 Test task Vivek Soni 2023-12-07 16:19:26 +0530
320445b08b

Update gilded_rose.rb abhishekpixo07 2023-12-07 15:12:37 +0530
3c25bffa4c Add the Conjured Gilded Rose items behaviour rverlind 2023-12-05 23:04:07 +0100
b846c986ed Extract the aging (Brie, Passes) Gilded Rose items behaviour rverlind 2023-12-05 22:53:30 +0100
fdd930f5cd Extract the legendary (Sulfuras) Gilded Rose item behaviour rverlind 2023-12-05 22:26:27 +0100
ce308107f2 Extract the standard Gilded Rose item behaviour rverlind 2023-12-05 22:06:08 +0100
31d2cb5a7b Add initial tests according to spec for standard items rverlind 2023-12-05 21:46:48 +0100
de03cc8f52

Update gildedrose.rs Maxwell A McKinnon 2023-12-05 11:01:50 -0800
2e30c563d8

Merge pull request #498 from codecop/master Emily Bache 2023-11-30 07:10:49 +0000
bcf8139af4 Fixed test cases Yash Dubey 2023-11-29 22:37:26 +0530
05be0f3c05 Enhancements and improvements in GildedRose Yash Dubey 2023-11-29 19:01:50 +0530
c83be7b8f4 sourceMap must be true for coverage to work with correct line numbers. Peter Kofler 2023-11-29 12:10:00 +0100
d9f80abd06 TS: Add an Approval base test similar to Java-Approvals and CS-xunit-verify using Jest Snapshot. Peter Kofler 2023-11-23 13:58:37 +0100
2a96f34022 Do not commit the lock file. Peter Kofler 2023-11-23 12:40:24 +0100
4d5ca7b311 PHP: Add an Approval base test similar to Java-Approvals and CS-xunit-verify. Peter Kofler 2023-11-23 12:24:27 +0100
7d758b5dc0

Merge pull request #497 from ronheywood/thirtyDaysTests Emily Bache 2023-11-28 09:00:44 +0000
9fd97e0fcb Tests named 30 days are run over 30 days Ron Heywood 2023-11-28 08:46:04 +0000
c7c479d683 Remove unnecessary files tbuckinx 2023-11-23 22:54:12 +0100
0102736d4c Final cleanup tbuckinx 2023-11-23 22:50:12 +0100
afc32f86f7 Cleanup tbuckinx 2023-11-23 22:42:46 +0100
d4ccdfe0e9 Refactoring abstract inventory item tbuckinx 2023-11-23 22:31:19 +0100
3b32b9a6bf Polymorphism refactoring tbuckinx 2023-11-23 22:28:59 +0100
3ad7c801f8 Refactor GildedRose class + add inventoryHelper + add conjuredItem test tbuckinx 2023-11-23 18:11:07 +0100
462d333bc5 Add integration tests for current requirements tbuckinx 2023-11-22 21:38:11 +0100
9c5090521c

Update README.md Emily Bache 2023-11-22 09:46:36 +0100
5fb60271e2

Merge pull request #495 from schlessera/fix/php-remove-final-from-item-class Emily Bache 2023-11-14 09:35:35 +0000
c64b2faf74

Remove final keyword from Item class Alain Schlesser 2023-11-14 09:14:39 +0000
0697cf49f0 Treat conjured items as well Remus Decea 2023-11-13 13:07:48 +0200
94f18f669e Extracted filters Remus Decea 2023-11-13 12:20:59 +0200
e07bca923b Generalize backstage Remus Decea 2023-11-13 12:13:02 +0200
5459470d10 Generalize Sulfuras condition Remus Decea 2023-11-13 11:57:20 +0200
36b6e62963 More streams Remus Decea 2023-11-13 11:50:06 +0200