Commit Graph

741 Commits

Author SHA1 Message Date
pierre
ca6cf0f665 chore: adding jacoco reports 2023-02-19 16:43:12 +01:00
pierre
2be976bde8 chore: adding comments for archlinux graddle user 2023-02-19 16:36:53 +01:00
pierre
e712c300f7 chore: adding description for README.md in JAVA folder 2023-02-19 16:34:05 +01:00
pierre
147762dd67 feat: adding jacoco plugin in the POM 2023-02-19 16:33:37 +01:00
Pierre
bc25fddb88
Merge pull request #6 from pcroch/feat/implementing_java_bean_convention_on_Item_class
Feat/implementing java bean convention on item class
2023-02-19 16:20:39 +01:00
pierre
8a2e2e7876 test: adding some others units tests for object Item 2023-02-19 16:16:51 +01:00
pierre
ce18e35be7 chore: change in the argument name for setters 2023-02-19 16:16:26 +01:00
pierre
f0fe95be85 feat: making the Item class respecting the Encapsulation Principle 2023-02-19 16:04:40 +01:00
Pierre
3c51e0ad35
Merge pull request #5 from pcroch/refactor/trying_to_simply_the_code
Refactor/trying to simply the code
2023-02-19 15:46:30 +01:00
pierre
1f1275f4db refactor: improving the placement of the SellIn Counter to make the placement more intuitive 2023-02-19 15:45:20 +01:00
pierre
2935556281 test: adding some more test case to increase coverage 2023-02-19 15:44:18 +01:00
pierre
557ba0eb73 chore: cleaning the class GildedRose.java 2023-02-19 15:30:17 +01:00
pierre
f6f99c1cef test; adding a new test cases 2023-02-19 15:29:26 +01:00
pierre
c68e0b3dcd chore: improving comments for better clarity 2023-02-19 15:13:36 +01:00
pierre
e326caf567 refactor: adding a guard clause for Sulfuras item to avoid to check later on 2023-02-19 15:12:49 +01:00
pierre
6154339c39 refactor: simplifying the condition when the SellIn value is negative 2023-02-19 15:04:49 +01:00
pierre
7473f39aec refactor: improving the if/else decision to avoid Logical NOT operator and ease the code comprehension 2023-02-19 14:46:19 +01:00
pierre
15f4d079a6 refactor: adding a guard clause in the updateItem method 2023-02-19 14:07:23 +01:00
pierre
0514a8ea67 test: changing the assert value 2023-02-19 13:53:35 +01:00
pierre
a6e85220e8 test: fine tunings the test cases to improve clarity 2023-02-19 13:48:51 +01:00
pierre
379648a572 feat: adding a updateItem method to keep the code dry 2023-02-19 13:29:50 +01:00
pierre
035e646326 refactor: moving up the gaurd clause for quality < 50 2023-02-19 13:16:32 +01:00
Pierre
0906d3c42b
Merge pull request #4 from pcroch/fix/completing_refactoring
Fix/completing refactoring
2023-02-19 13:12:17 +01:00
pierre
095d5edc82 refactor: change the test cases name to improve clarity 2023-02-19 12:57:57 +01:00
pierre
102adc0792 fix: updating the tesText file for the product decreasing quality 2023-02-19 12:39:21 +01:00
pierre
6c46c2d182 fix: updating a test case 2023-02-19 12:37:01 +01:00
pierre
a19592a19f feat: adding new products 2023-02-19 12:36:49 +01:00
pierre
85cafea70a feat: adding a test cases 2023-02-19 11:54:38 +01:00
Pierre
327d26c7dd
Merge pull request #3 from pcroch/refactor/refactoring_the_updateQuality_Class
Refactor/refactoring the update quality class
2023-02-19 10:36:30 +01:00
pierre
33f38a7ec9 refactor: making the UpdateQuality method more readable by removing the tree of if/else statements while adding more specific tests cases to avoid regression 2023-02-19 10:33:27 +01:00
pierre
ef58e2bf7a fix: fixing the itemSulfurasNotChangeQuality test case 2023-02-18 18:38:02 +01:00
pierre
f691744b2b refactor: adding more test cases to increase testing coverage 2023-02-18 18:12:01 +01:00
pierre
a81faa5f29 refactor: moving up guard clause for TAFKAL80ETC Concert if quality is inferior to 50 2023-02-18 17:34:19 +01:00
Pierre
f2b170a736
Merge pull request #2 from pcroch/feat/adding_test_cases_for_improve_coverage
Feat/adding test cases for improve coverage
2023-02-18 17:13:04 +01:00
pierre
34f7bb83b1 refactor: moving COnjured test cases into the UpdateQualityTest class 2023-02-18 17:11:42 +01:00
pierre
01718e904e feat: adding testing for incoming features 2023-02-18 17:00:51 +01:00
pierre
4bf6facef3 feat: adding basic unit tests for the GildedRose.java class 2023-02-18 16:35:16 +01:00
Pierre
6bcf21d33b
Merge pull request #1 from pcroch/init/initial_setup_of_repo
Init/initial setup of repo
2023-02-18 15:06:00 +01:00
pierre
70ad8fa790 fix: changing config file to run the app locally 2023-02-18 15:00:37 +01:00
pierre
0a49bf842f test: saving the initial test snapshot for later testing 2023-02-18 14:52:37 +01:00
Emily Bache
820e796fd8
Merge pull request #405 from nitsanavni/add-ci
add ci - start with jq
2023-02-08 08:30:44 +01:00
Nitsan Avni
8ee93709a5 jq ci: compare to 30 days texttest stdout 2023-02-07 17:13:45 +00:00
Nitsan Avni
e7545c322e back to green, rename job 2023-02-07 17:12:18 +00:00
Nitsan Avni
6f17a85b91 intentionally fail the ci 2023-02-07 17:12:18 +00:00
Nitsan Avni
714d60b092 ci: test texttest result 2023-02-07 17:12:18 +00:00
Nitsan Avni
f982992850 diff action 2023-02-07 17:12:18 +00:00
Nitsan Avni
6527ea8bc3 add jq.yml workflow 2023-02-07 17:12:18 +00:00
Emily Bache
0fa2c2e623
Merge pull request #404 from nitsanavni/jq
add jq translation
2023-02-07 16:10:27 +01:00
Nitsan Avni
9a2736d267 use foreach for extra indentation 2023-02-07 08:35:39 +00:00
Nitsan Avni
9abe955027 add jq translation 2023-02-06 22:41:03 +00:00